Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly look for inline methods #15072

Merged
merged 1 commit into from May 30, 2022
Merged

Properly look for inline methods #15072

merged 1 commit into from May 30, 2022

Conversation

nicolasstucki
Copy link
Contributor

This fixes a false positive where we mistakenly interpreted an
inline val as an inline method.

Fixes #14679

This fixes a false positive where we mistakenly interpreted an
`inline val` as an inline method.

Fixes scala#14679
@nicolasstucki nicolasstucki self-assigned this Apr 29, 2022
@nicolasstucki nicolasstucki marked this pull request as ready for review May 4, 2022 08:10
@nicolasstucki nicolasstucki added this to the 3.2.0-RC1 milestone May 24, 2022
@nicolasstucki nicolasstucki added the fasttrack Simple fix. Reviewer should merge or apply additional changes directly. label May 24, 2022
Copy link
Member

@mbovel mbovel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I completely missed this PR. Looks great, let's get that merged!

@mbovel mbovel merged commit 95ae793 into scala:main May 30, 2022
@mbovel mbovel deleted the fix-14679 branch May 30, 2022 13:24
@Kordyjan Kordyjan modified the milestones: 3.2.0-RC1, 3.2.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fasttrack Simple fix. Reviewer should merge or apply additional changes directly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compiler throw AssertionError inline val a = ${b}
3 participants