Call graph with DCE #1840

Closed
wants to merge 345 commits into
from

Conversation

Projects
None yet
6 participants
@nicolasstucki
Contributor

nicolasstucki commented Dec 20, 2016

No description provided.

+ if (tp1.dealias ne tp1) registerParentModules(tp1.dealias, from)
+ if (tp1.termSymbol.is(Module)) {
+ addReachableType(new TypeWithContext(tp1.widenDealias, parentRefinements(tp1.widenDealias)), from)
+ } else if (tp1.typeSymbol.is(Module, Package)) {

This comment has been minimized.

@smarter

smarter Feb 8, 2017

Member

write butNot = Package instead of just Package otherwise it's confusing

@smarter

smarter Feb 8, 2017

Member

write butNot = Package instead of just Package otherwise it's confusing

- addReachableType(new TypeWithContext(t, parentRefinements(t)), from)
- }
- register(tp1.normalizedPrefix)
+ private val registeredTypes = mutable.Set.empty[Type]

This comment has been minimized.

@DarkDimius

DarkDimius Mar 14, 2017

Member

does it speed up?
Actually you could use reachableTypes instead of this set.

@DarkDimius

DarkDimius Mar 14, 2017

Member

does it speed up?
Actually you could use reachableTypes instead of this set.

This comment has been minimized.

@nicolasstucki

nicolasstucki Mar 14, 2017

Contributor

Yes, it does. reachableTypes does not help much in this case.

@nicolasstucki

nicolasstucki Mar 14, 2017

Contributor

Yes, it does. reachableTypes does not help much in this case.

Roldak and others added some commits Nov 23, 2016

Fix double collection of method summaries.
Also adds CG bound checks on tests for regression testing.
- moduleRoot.hack = result
+ result match {
+ case result @ Some(_: DottyUnpickler) =>
+ classRoot.dottyUnpickler = result.asInstanceOf[Option[DottyUnpickler]]

This comment has been minimized.

@smarter

smarter May 3, 2017

Member

I see we have the same kind of problems :). dotty-staging@118fa0f

@smarter

smarter May 3, 2017

Member

I see we have the same kind of problems :). dotty-staging@118fa0f

@felixmulder felixmulder added this to the 0.2 Tech Preview milestone May 29, 2017

@DarkDimius

This comment has been minimized.

Show comment
Hide comment
@DarkDimius

DarkDimius May 31, 2017

Member

Not in time for release, rescheduling to next one.

Member

DarkDimius commented May 31, 2017

Not in time for release, rescheduling to next one.

@felixmulder felixmulder modified the milestones: 0.2 Tech Preview, 0.3 Tech Preview Jun 27, 2017

@nicolasstucki nicolasstucki removed this from the 0.5 Tech Preview milestone Oct 25, 2017

@nicolasstucki

This comment has been minimized.

Show comment
Hide comment
@nicolasstucki

nicolasstucki Oct 31, 2017

Contributor

Closing this for now, it will need a bit of work while rebasing.

Contributor

nicolasstucki commented Oct 31, 2017

Closing this for now, it will need a bit of work while rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment