New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE: Support jump to definition in imports #4199

Merged
merged 21 commits into from Nov 16, 2018

Conversation

Projects
None yet
3 participants
@Duhemm
Copy link
Contributor

Duhemm commented Mar 27, 2018

No description provided.

@allanrenucci allanrenucci requested a review from smarter Mar 28, 2018

@Duhemm Duhemm force-pushed the dotty-staging:topic/go-to-definition-imports branch from 5ff0200 to 0182e4c Apr 4, 2018

@Duhemm Duhemm assigned smarter and unassigned Duhemm Apr 4, 2018

@Duhemm Duhemm added the stat:on hold label Apr 11, 2018

@Duhemm

This comment has been minimized.

Copy link
Contributor

Duhemm commented Apr 11, 2018

This PR should probably wait for the IDE tests (#3766) to be merged.

@Duhemm Duhemm force-pushed the dotty-staging:topic/go-to-definition-imports branch from 0182e4c to 4aa799e Apr 12, 2018

@Duhemm Duhemm removed the stat:on hold label Apr 12, 2018

@Duhemm Duhemm force-pushed the dotty-staging:topic/go-to-definition-imports branch from 4aa799e to 421b6ce Apr 23, 2018

@Duhemm Duhemm force-pushed the dotty-staging:topic/go-to-definition-imports branch from 421b6ce to eab4b3b May 1, 2018

@Duhemm Duhemm force-pushed the dotty-staging:topic/go-to-definition-imports branch from eab4b3b to 9663752 Aug 21, 2018

@Duhemm

This comment has been minimized.

Copy link
Contributor

Duhemm commented Aug 21, 2018

Rebased on latest master

@Duhemm Duhemm force-pushed the dotty-staging:topic/go-to-definition-imports branch from e3d69c9 to 52e76f6 Sep 4, 2018

@Duhemm Duhemm force-pushed the dotty-staging:topic/go-to-definition-imports branch from 52e76f6 to fb2ac33 Oct 15, 2018

@Duhemm

This comment has been minimized.

Copy link
Contributor

Duhemm commented Oct 15, 2018

@smarter I think I've addressed your first comments. My reply to your comment about the new AST node is hidden, but it's here

@Duhemm Duhemm force-pushed the dotty-staging:topic/go-to-definition-imports branch 2 times, most recently from bee2d3f to b44e3b2 Oct 19, 2018

@Duhemm

This comment has been minimized.

Copy link
Contributor

Duhemm commented Oct 29, 2018

@smarter I've added support for renaming renamed symbols. RenameTree is gone, too.

@Duhemm Duhemm force-pushed the dotty-staging:topic/go-to-definition-imports branch 2 times, most recently from 8aa5176 to a74b52a Nov 13, 2018

Duhemm added some commits Oct 12, 2018

Be less precise about renaming and imports
 This commit makes the renaming less precise for the (probably rare)
 case of an imports being imported multiple times with the same
 renaming.

 When doing a renaming of a symbol that is import-renamed, we would
 exclude subscope where the same symbol was imported again with the same
 name. This commit changes the logic so that we no longer exclude those
 subscope, and keep renaming.

 See RenameTest#renameRenamingImportNested for an example where the
 langauge server will now behave differently.
Be even less precise about renaming with imports
Renaming a symbol that has been import-renamed will now rename all
occurrences of that symbol with the new name in the whole file,
regardless of scope.
Remove `SourceImportTree`
We keep only `SourceTree`, that we had before, but it now accepts any
`tpd.Tree`. After we bootstrap, this should become `tpd.Import |
tpd.NameTree`.
Improve renaming with overridden symbols
When renaming a symbol that overrides other symbols, the overridden
symbols and all their overrides will be renamed too.
Ask user when renaming overriding symbols
When renaming a symbol that is overriding another symbol, we now ask the
user whether we should rename the base symbol or only this member.

@Duhemm Duhemm force-pushed the dotty-staging:topic/go-to-definition-imports branch from a74b52a to ec6882c Nov 13, 2018

Show documentation for all imported symbols
When doing hover on an imported node, the window now shows the
documentation for all the imported symbols.
@smarter
Copy link
Member

smarter left a comment

🌟 💞

@Duhemm Duhemm merged commit 614265d into lampepfl:master Nov 16, 2018

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr the build was successful
Details

@Duhemm Duhemm deleted the dotty-staging:topic/go-to-definition-imports branch Nov 16, 2018

@Duhemm

This comment has been minimized.

Copy link
Contributor

Duhemm commented Nov 16, 2018

Thanks a lot for the numerous reviews @smarter !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment