Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #5124 #5125

Merged
merged 2 commits into from Sep 20, 2018

Conversation

Projects
None yet
3 participants
@melekhove
Copy link
Contributor

commented Sep 19, 2018

This patch provides small fix for #5124. After applying it all language-server tests pass OK on Windows.

@dotty-bot
Copy link

left a comment

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@smarter
Copy link
Member

left a comment

Otherwise LGTM, thanks!

val dottyIdeJson: String =
s"""[ {
| "id" : "dotty-ide-test",
| "compilerVersion" : "${BuildInfo.ideTestsCompilerVersion}",
| "compilerArguments" : ${showSeq(BuildInfo.ideTestsCompilerArguments)},
| "sourceDirectories" : ${showSeq(BuildInfo.ideTestsSourceDirectories)},
| "dependencyClasspath" : ${showSeq(BuildInfo.ideTestsDependencyClasspath)},
| "classDirectory" : "${BuildInfo.ideTestsClassDirectory}"
| "classDirectory" : "${BuildInfo.ideTestsClassDirectory.toString().replace('\\','/')}"

This comment has been minimized.

Copy link
@smarter

smarter Sep 19, 2018

Member

No need for the parentheses after toString

This comment has been minimized.

Copy link
@melekhove

melekhove Sep 19, 2018

Author Contributor

Sorry, Java habits. Will fix.
Should I amend or just new commit is OK?

@smarter

This comment has been minimized.

Copy link
Member

commented Sep 19, 2018

New commit is fine here, in general we don't have a strong policy for commits, but I personally prefer having a clean history when possible.

@smarter smarter merged commit e34bb2d into lampepfl:master Sep 20, 2018

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr the build was successful
Details

@melekhove melekhove deleted the melekhove:issue/5124 branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.