New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worksheet improvements #5230

merged 3 commits into from Oct 10, 2018


None yet
2 participants
Copy link

smarter commented Oct 10, 2018

No description provided.

vscode-dotty: typesafe messages
This replaces the use of strings for identifying messages by
types (WorksheetExecRequest and WorksheetPublishOutputNotification).

Also contains some light cleanup/uniformization

@smarter smarter requested a review from Duhemm Oct 10, 2018

Copy link

Duhemm left a comment

That's indeed a lot cleaner 👍

Show resolved Hide resolved vscode-dotty/src/features.ts
Show resolved Hide resolved vscode-dotty/src/features.ts Outdated
Show resolved Hide resolved vscode-dotty/src/features.ts

smarter added some commits Oct 10, 2018

Refactor worksheet support, make it a dynamic feature
- Only enable worksheet features on the client if the server supports
them using the LSP support for dynamic feature registration.
- Replace the global functions and state in worksheet.ts by a
WorksheetProvider class, move some of the global functions specific to
one worksheet into Worksheet
Standardize vocabulary around running the worksheet
We used interchangeably the term "run", "evaluate" and "exec" for
talking about running a worksheet. This commit does a lot of renaming
to standardize on using "run" everywhere.

@smarter smarter force-pushed the dotty-staging:worksheet-stuff branch from 50ce4a0 to 59ceea9 Oct 10, 2018

@smarter smarter changed the title [WIP] Worksheet improvements Worksheet improvements Oct 10, 2018


This comment has been minimized.

Copy link

smarter commented Oct 10, 2018

Going to merge this as-is and open another PR for further improvements.

@smarter smarter merged commit d9e7574 into lampepfl:master Oct 10, 2018

1 of 2 checks passed

continuous-integration/drone/pr this build is pending
CLA User signed CLA

@allanrenucci allanrenucci deleted the dotty-staging:worksheet-stuff branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment