New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to highlight comments in repl #5301

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@veera83372
Copy link
Contributor

veera83372 commented Oct 20, 2018

Fixes #5169

@dotty-bot
Copy link

dotty-bot left a comment

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@allanrenucci allanrenucci self-assigned this Oct 24, 2018

@allanrenucci
Copy link
Member

allanrenucci left a comment

Hi @veera83372. Thanks for the contribution and sorry for the late review.

@allanrenucci
Copy link
Member

allanrenucci left a comment

Otherwise LGTM. Can you squash your commits?

@veera83372 veera83372 force-pushed the veera83372:repl_comments_highlight branch from b27e226 to 49394e0 Nov 13, 2018

@allanrenucci allanrenucci merged commit bf5ba46 into lampepfl:master Nov 13, 2018

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr the build was successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment