New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tasty files to be the input of -from-tasty #5325

Merged
merged 6 commits into from Nov 23, 2018

Conversation

Projects
None yet
3 participants
@nicolasstucki
Copy link
Contributor

nicolasstucki commented Oct 25, 2018

Also works for -decompile and any other compiler that has the -form-tatsy flag.

@nicolasstucki

This comment has been minimized.

Copy link
Contributor

nicolasstucki commented Oct 25, 2018

@tuvior try using this. @Duhemm this may help you for #5081

@nicolasstucki nicolasstucki force-pushed the dotty-staging:add-tasty-file-input branch from ce7f403 to 9ff94c9 Oct 25, 2018

@nicolasstucki nicolasstucki requested a review from smarter Oct 26, 2018

Show resolved Hide resolved compiler/src/dotty/tools/dotc/Driver.scala Outdated
@tuvior

This comment has been minimized.

Copy link
Contributor

tuvior commented Oct 26, 2018

classes in default package return <empty> as the package

[error] class <empty>.varargs cannot be unpickled because no class file was found

Complete reimplantation

@nicolasstucki

This comment has been minimized.

Copy link
Contributor

nicolasstucki commented Nov 7, 2018

@tuvior could you try this new version of the fix on your branch to see if all the issues we identified are gone.

@nicolasstucki nicolasstucki requested a review from smarter Nov 8, 2018

@nicolasstucki nicolasstucki force-pushed the dotty-staging:add-tasty-file-input branch from f4ada7d to 2181000 Nov 13, 2018

@nicolasstucki nicolasstucki force-pushed the dotty-staging:add-tasty-file-input branch from 77c5c51 to 830cdb1 Nov 13, 2018

@nicolasstucki

This comment has been minimized.

Copy link
Contributor

nicolasstucki commented Nov 22, 2018

@smarter do not forget to review this one

@nicolasstucki nicolasstucki force-pushed the dotty-staging:add-tasty-file-input branch from f4c32a2 to 0bf8b17 Nov 22, 2018

@nicolasstucki nicolasstucki merged commit 30b8b1c into lampepfl:master Nov 23, 2018

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr the build was successful
Details

@nicolasstucki nicolasstucki deleted the dotty-staging:add-tasty-file-input branch Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment