New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5372: Use `applyDynamic` in structural calls #5377

Merged
merged 1 commit into from Nov 3, 2018

Conversation

Projects
None yet
3 participants
@Duhemm
Copy link
Contributor

Duhemm commented Nov 2, 2018

This commit changes how Selectable works for calling methods: It used
to be called `selectMethodDynamic and to receive the name of the method
to call along with the class tags of the formal parameters.

This commit renames it to applyDynamic, and changes it so that it also
takes the actual arguments that are passed in the function call.

Fixes #5372

Fix #5372: Use `applyDynamic` in structural calls
This commit changes how `Selectable` works for calling methods: It used
to be called `selectMethodDynamic and to receive the name of the method
to call along with the class tags of the formal parameters.

This commit renames it to `applyDynamic`, and changes it so that it also
takes the actual arguments that are passed in the function call.

Fixes #5372

@Duhemm Duhemm requested a review from odersky Nov 2, 2018

@sjrd

This comment has been minimized.

Copy link
Member

sjrd commented Nov 2, 2018

Nice, thank you! I'm especially pleased to see that it actually reduces complexity in Selectable.scala, and that it removes the 7 limit restriction. :)

@odersky

odersky approved these changes Nov 3, 2018

Copy link
Contributor

odersky left a comment

Looks great! I am amazed how fast this went.

@odersky odersky merged commit 8610cdb into lampepfl:master Nov 3, 2018

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr the build was successful
Details

@allanrenucci allanrenucci deleted the dotty-staging:fix/5372 branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment