New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE: Support `textDocument/signatureHelp` #5395

Merged
merged 4 commits into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@Duhemm
Copy link
Contributor

Duhemm commented Nov 6, 2018

ezgif com-optimize

Depends on #5394 and #5393 (only because a test exercises it)

@Duhemm Duhemm added the area:ide label Nov 6, 2018

@smarter
Copy link
Member

smarter left a comment

Could type parameters be considered as a parameter list too ?

@Duhemm

This comment has been minimized.

Copy link
Contributor

Duhemm commented Nov 12, 2018

Could type parameters be considered as a parameter list too ?

I've tried, but failed so far. I also tried to handle named arguments, but these are discarded by the typer when the application doesn't type check. I've tried keeping them, but it got hairy.

It would be nice to get that to work, but I believe that this could be left as a future improvement.

@Duhemm Duhemm force-pushed the dotty-staging:topic/ide-signature-help branch from 2d612ea to d15a501 Nov 12, 2018

@smarter

This comment has been minimized.

Copy link
Member

smarter commented Nov 12, 2018

It would be nice to get that to work, but I believe that this could be left as a future improvement.

Sure, we should open an issue to not forget abou that.

@Duhemm

This comment has been minimized.

Copy link
Contributor

Duhemm commented Nov 13, 2018

@smarter Do you have more comments or is this good to go?

@Duhemm Duhemm force-pushed the dotty-staging:topic/ide-signature-help branch from d15a501 to 9d32de2 Nov 13, 2018

Duhemm and others added some commits Nov 5, 2018

Error message for `none of the overloaded...`
This error message allows us to keep track of all the possible
alternatives.
IDE: Support `textDocument/signatureHelp`
When the user starts writing a function application, the language client
requests `textDocument/signatureHelp`. This is used to display help
associated with the function application that is being written.
Improve readability
Co-Authored-By: Duhemm <martin.duhem@gmail.com>
Move `Signatures` to `dotty.tools.dotc.util`
And address review comments.

@Duhemm Duhemm force-pushed the dotty-staging:topic/ide-signature-help branch from 9d32de2 to 25d436b Nov 13, 2018

@Duhemm Duhemm merged commit 7824363 into lampepfl:master Nov 13, 2018

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr the build was successful
Details

@Duhemm Duhemm deleted the dotty-staging:topic/ide-signature-help branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment