New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record anonymous child classes for exhaustivity check #5396

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
3 participants
@liufengyun
Copy link
Contributor

liufengyun commented Nov 6, 2018

Record anonymous child classes for exhaustivity check

@liufengyun

This comment has been minimized.

Copy link
Contributor

liufengyun commented Nov 6, 2018

@nicolasstucki could you please give some help with the decompile failure in CI? I run the following on my local machine:

sbt > dotc -Ythrough-tasty -Ycheck:all tests/pos/t8324.scala

It works without any problem.

@nicolasstucki

This comment has been minimized.

Copy link
Contributor

nicolasstucki commented Nov 6, 2018

I will have a look

@nicolasstucki

This comment has been minimized.

Copy link
Contributor

nicolasstucki commented Nov 6, 2018

@liufengyun the issue was not a fromtasty compilation one. It was about recompiling decompiled code. I remove it from the whitelist. Now it should work.

@nicolasstucki

This comment has been minimized.

Copy link
Contributor

nicolasstucki commented Nov 6, 2018

@liufengyun you still have a pickling test failing (t8611b)

@liufengyun

This comment has been minimized.

Copy link
Contributor

liufengyun commented Nov 6, 2018

Thanks a lot @nicolasstucki for the fix.

Record anonymous child classes for exhaustivity check
If a sealed class A has local or anonymous classes, add the
annotation `Child(A)` to `A`. With this simple change, the
exhaustivity check works without any modification.

@liufengyun liufengyun force-pushed the dotty-staging:check-anonym branch from 6bb198a to 1a8eefe Nov 7, 2018

@smarter smarter referenced this pull request Nov 7, 2018

Closed

False unreachable warning #1917

@odersky

odersky approved these changes Nov 8, 2018

@liufengyun liufengyun merged commit b261160 into lampepfl:master Nov 9, 2018

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr the build was successful
Details

@liufengyun liufengyun deleted the dotty-staging:check-anonym branch Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment