New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE: Support `textDocument/implementation` #5401

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@Duhemm
Copy link
Contributor

Duhemm commented Nov 7, 2018

Works with ⌘F12 / <ctrl>F12, or Go > Go to Implementation

Depends on #5209, only the last commit is new.

@Duhemm Duhemm added the area:ide label Nov 7, 2018

@Duhemm Duhemm force-pushed the dotty-staging:topic/ide-implementation branch from 8477cd4 to 74ad15c Nov 7, 2018

@smarter

smarter approved these changes Nov 9, 2018

Copy link
Member

smarter left a comment

Last commit LGTM

Duhemm added some commits Nov 7, 2018

IDE: Support `textDocument/implementation`
This is used to find implementations of the symbol under the cursor.

@Duhemm Duhemm force-pushed the dotty-staging:topic/ide-implementation branch from 74ad15c to 858731b Nov 13, 2018

@Duhemm

This comment has been minimized.

Copy link
Contributor

Duhemm commented Nov 13, 2018

@smarter I've addressed your comments, do you want to take another look?

@Duhemm Duhemm merged commit bdd932f into lampepfl:master Nov 13, 2018

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr the build was successful
Details

@Duhemm Duhemm deleted the dotty-staging:topic/ide-implementation branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment