New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5397: Visit local method in Tailrec #5431

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
3 participants
@allanrenucci
Copy link
Member

allanrenucci commented Nov 12, 2018

If a method is annotated with @tailrec we now report invalid recursive
call within local method. This means we now visit by-name arguments,
closures and lifted trys

@allanrenucci allanrenucci force-pushed the dotty-staging:fix-5397 branch 3 times, most recently from c48f7fa to 56ab2f2 Nov 13, 2018

@allanrenucci allanrenucci requested a review from sjrd Nov 13, 2018

@sjrd

sjrd approved these changes Nov 14, 2018

Show resolved Hide resolved tests/neg/i5397.scala Outdated

@sjrd sjrd assigned allanrenucci and unassigned sjrd Nov 14, 2018

Fix #5397: Visit local methods and values in Tailrec
If a method is annotated with @tailrec we now report invalid recursive
call within local method. This means we now visit by-name arguments,
closures and lifted `try`s

@allanrenucci allanrenucci force-pushed the dotty-staging:fix-5397 branch from 56ab2f2 to 4d9d4fa Nov 14, 2018

@allanrenucci allanrenucci merged commit 6448998 into lampepfl:master Nov 14, 2018

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr the build was successful
Details

@allanrenucci allanrenucci deleted the dotty-staging:fix-5397 branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment