New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition to TASTy reflect to semantic DB #5435

Merged
merged 19 commits into from Nov 22, 2018

Conversation

Projects
None yet
4 participants
@poechsel
Copy link
Contributor

poechsel commented Nov 13, 2018

PR from my work on a tasty to semanticDB converter.

This PR is mostly to merge the addition I've made to tasty-reflect (added an accessor for exists on Position and accessors to companionClass, companionModule and pos on Symbol).

The converter itself is under ongoing work and is not production ready.

@dotty-bot
Copy link

dotty-bot left a comment

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@nicolasstucki nicolasstucki self-requested a review Nov 14, 2018

@nicolasstucki nicolasstucki self-assigned this Nov 14, 2018

@nicolasstucki

This comment has been minimized.

Copy link
Contributor

nicolasstucki commented Nov 17, 2018

@poechsel looks like you have to rebase. There are some conflicts with documentation lines.

@poechsel poechsel force-pushed the poechsel:tasty-to-semanticdb branch from 7edd2f3 to d00e18a Nov 17, 2018

Show resolved Hide resolved semanticdb/Makefile Outdated

@poechsel poechsel force-pushed the poechsel:tasty-to-semanticdb branch from d00e18a to 4a5314d Nov 20, 2018

@nicolasstucki nicolasstucki changed the title Addition to tasty reflect Addition to TASTy reflect to semantic DB Nov 22, 2018

The make file was removed in favour of logic in the sbt build

@nicolasstucki
Copy link
Contributor

nicolasstucki left a comment

Otherwise LGTM

@nicolasstucki nicolasstucki merged commit 7652a2f into lampepfl:master Nov 22, 2018

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr the build was successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment