New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing TASTy reflect instance checks #5504

Merged
merged 3 commits into from Nov 26, 2018

Conversation

Projects
None yet
2 participants
@nicolasstucki
Copy link
Contributor

nicolasstucki commented Nov 23, 2018

No description provided.

@nicolasstucki nicolasstucki self-assigned this Nov 23, 2018

@nicolasstucki nicolasstucki force-pushed the dotty-staging:add-missing-tasty-instance-checks branch from e5c0f50 to 8e5b76d Nov 23, 2018

@nicolasstucki nicolasstucki changed the title Add missing tasty instance checks Add missing TASTy reflect instance checks Nov 23, 2018

@liufengyun
Copy link
Contributor

liufengyun left a comment

LGTM

For later refactoring: maybe a better name than IsXXX, which suggests a boolean extractor.

@nicolasstucki nicolasstucki merged commit 63ee01a into lampepfl:master Nov 26, 2018

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr the build was successful
Details

@nicolasstucki nicolasstucki deleted the dotty-staging:add-missing-tasty-instance-checks branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment