Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-contextualize Liftable.toExpr #6924



Copy link

commented Jul 24, 2019

Redefine Liftable.toExpr as def toExpr(x: T): given QuoteContext => Expr[T].
This change makes it simpler to implement Liftable as the return type can be omitted.

Extracted from #6881 where this change aligns with the new quotes internal representation.

@nicolasstucki nicolasstucki self-assigned this Jul 24, 2019

Recontextualize Liftable.toExpr
Redefine `Liftable.toExpr` as `def toExpr(x: T): given QuoteContext => Expr[T]`.
This change makes it simpler to implement `Liftable` as the return type can be omitted.

@nicolasstucki nicolasstucki force-pushed the dotty-staging:recontextualize-liftable-toexpr branch from ddc12dd to 2425707 Jul 24, 2019

@nicolasstucki nicolasstucki marked this pull request as ready for review Jul 24, 2019

@nicolasstucki nicolasstucki requested a review from anatoliykmetyuk Jul 24, 2019

Copy link

left a comment

Nice, the code is more concise now!

@anatoliykmetyuk anatoliykmetyuk merged commit 7247651 into lampepfl:master Jul 24, 2019

2 checks passed

CLA User signed CLA
continuous-integration/drone/pr Build is passing

@anatoliykmetyuk anatoliykmetyuk deleted the dotty-staging:recontextualize-liftable-toexpr branch Jul 24, 2019

@anatoliykmetyuk anatoliykmetyuk added this to the 0.18 Tech Preview milestone Aug 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.