Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `scala.quoted.Liftable`s to the stdlib #6928

Merged
merged 10 commits into from Jul 26, 2019

Conversation

@nicolasstucki
Copy link
Contributor

commented Jul 24, 2019

No description provided.

@nicolasstucki nicolasstucki changed the title Add `quoted.Liftable[List[T]]` to the stdlib Add liftables to the stdlib Jul 24, 2019

@nicolasstucki nicolasstucki changed the title Add liftables to the stdlib Add `scala.quoted.Liftable`s to the stdlib Jul 24, 2019

@nicolasstucki nicolasstucki self-assigned this Jul 24, 2019

@nicolasstucki nicolasstucki force-pushed the dotty-staging:add-liftables-to-stdlib branch from 31c0f08 to 3340db1 Jul 24, 2019

@nicolasstucki nicolasstucki requested a review from biboudis Jul 24, 2019

@nicolasstucki nicolasstucki removed their assignment Jul 24, 2019

@nicolasstucki nicolasstucki requested review from liufengyun and removed request for biboudis Jul 24, 2019

@nicolasstucki nicolasstucki marked this pull request as ready for review Jul 24, 2019

@liufengyun
Copy link
Contributor

left a comment

LGTM

library/src/scala/quoted/Liftable.scala Outdated Show resolved Hide resolved
library/src/scala/quoted/Liftable.scala Show resolved Hide resolved
given [T1: Type: Liftable] as Liftable[Tuple1[T1]] = new {
def toExpr(tup: Tuple1[T1]) =
'{ Tuple1(${tup._1.toExpr}) }
}

This comment has been minimized.

Copy link
@liufengyun

liufengyun Jul 26, 2019

Contributor

Minor: maybe still write new Liftable[...] to be consistent and explicit as above, the same for the code below

This comment has been minimized.

Copy link
@nicolasstucki

nicolasstucki Jul 26, 2019

Author Contributor

It got way too long and made it harder to read.

@nicolasstucki nicolasstucki force-pushed the dotty-staging:add-liftables-to-stdlib branch from 08d9b6b to 5796226 Jul 26, 2019

@nicolasstucki nicolasstucki requested a review from liufengyun Jul 26, 2019

@liufengyun
Copy link
Contributor

left a comment

LGTM

@nicolasstucki nicolasstucki force-pushed the dotty-staging:add-liftables-to-stdlib branch from 5d46185 to 36186f0 Jul 26, 2019

@nicolasstucki nicolasstucki force-pushed the dotty-staging:add-liftables-to-stdlib branch from 36186f0 to 81dd055 Jul 26, 2019

@nicolasstucki nicolasstucki merged commit 746653e into lampepfl:master Jul 26, 2019

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr Build is passing
Details

@nicolasstucki nicolasstucki deleted the dotty-staging:add-liftables-to-stdlib branch Jul 26, 2019

@anatoliykmetyuk anatoliykmetyuk added this to the 0.18 Tech Preview milestone Aug 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.