Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quoted ExprOps toExprOfSeq #6935

Merged

Conversation

@nicolasstucki
Copy link
Contributor

commented Jul 25, 2019

The implementation of toExprOfSeq uses TASTy reflect to generate the most compact code possible. It also gives an efficient way to splice varargs.

@nicolasstucki nicolasstucki requested a review from liufengyun Jul 25, 2019

@nicolasstucki nicolasstucki self-assigned this Jul 25, 2019

Add quoted ExprOps toExprOfSeq
The implementation of `toExprOfSeq` uses TASTy reflect to generate the most compact code possible.
It also gives an efficient way to splice varargs.

@nicolasstucki nicolasstucki force-pushed the dotty-staging:add-quoted-ExprOps-toExprOfList branch from d88e45c to 8f85154 Jul 25, 2019

@liufengyun
Copy link
Contributor

left a comment

LGTM

@nicolasstucki nicolasstucki merged commit 4bfafbf into lampepfl:master Jul 26, 2019

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr Build is passing
Details

@nicolasstucki nicolasstucki deleted the dotty-staging:add-quoted-ExprOps-toExprOfList branch Jul 26, 2019

@anatoliykmetyuk anatoliykmetyuk added this to the 0.18 Tech Preview milestone Aug 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.