Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Scala.js mode, compile all lazy vals as thread-unsafe. #7026

Merged
merged 4 commits into from Aug 12, 2019

Conversation

@sjrd
Copy link
Member

commented Aug 12, 2019

Since JS is a single-threaded environment, there is no point going through all the machinery of thread-safe lazy vals.

This fixes lazy vals for JS, which would previously fail to link because of the dependency on Unsafe, which is not supported in Scala.js.

The first 3 commits fix a few other bugs in the JS codegen, that prevented Base64Test from compiling. Base64Test contains lazy vals and is therefore an appropriate test for the last commit.

sjrd added 4 commits Aug 12, 2019
Fix JS code gen for Byte, Short and Char literals.
They were all erroneously translated to `IntLiteral`s.
Fix JS codegen for closures calling static methods.
They had better pass the actual parameters, in addition to the
captures.
Fix `toIRType` for Chars, Bytes and Shorts.
They were all erroneously translated to `jstpe.IntType`.
In Scala.js mode, compile all lazy vals as thread-unsafe.
Since JS is a single-threaded environment, there is no point going
through all the machinery of thread-safe lazy vals.

This fixes lazy vals for JS, which would previously fail to link
because of the dependency on `Unsafe`, which is not supported in
Scala.js.

@sjrd sjrd requested a review from odersky Aug 12, 2019

@dotty-bot
Copy link

left a comment

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@sjrd

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

@odersky I tested that sjsJUnitTests/test passes (including compilation of the dotty-library-bootstrappedJS library) when this PR and #7006 are merged together.

@sjrd sjrd merged commit 81c240a into lampepfl:master Aug 12, 2019

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr Build is passing
Details

@sjrd sjrd deleted the dotty-staging:fix-sjs-lazy-vals branch Aug 12, 2019

@anatoliykmetyuk anatoliykmetyuk added this to the 0.18 Tech Preview milestone Aug 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.