Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release sbt-dotty 0.3.4, future-proof isDotty #7120

Merged
merged 3 commits into from Aug 28, 2019

Conversation

@smarter
Copy link
Member

commented Aug 28, 2019

We need a released sbt-dotty with f5459d0#diff-2341add22275f228b7ecd69d80025b8a in.

I'm doing the sbt-dotty release manually as usual by running:

drone build promote lampepfl/dotty $BUILD_ID sbt_release

@smarter smarter requested a review from bishabosha Aug 28, 2019

@anatoliykmetyuk anatoliykmetyuk added this to the 0.18 Tech Preview milestone Aug 28, 2019

@bishabosha
Copy link
Member

left a comment

LGTM

Make test t6827 less flaky
It failed once on the CI on OpenJDK 8 because the toString of the
exception was "java.lang.ArrayIndexOutOfBoundsException" instead of
"java.lang.ArrayIndexOutOfBoundsException:-1"
(https://dotty-ci.epfl.ch/lampepfl/dotty/982/1/4). I have no idea how
this could happen (different code paths between the interpreted and JIT
compiled code ?), so just stop checking for the exact toString output.

@smarter smarter force-pushed the dotty-staging:sbt-dotty-0.3.4 branch from 863a67f to bcbbbc0 Aug 28, 2019

@smarter smarter merged commit 13a9f4b into lampepfl:master Aug 28, 2019

2 checks passed

CLA User signed CLA
Details
continuous-integration/drone/pr Build is passing
Details

@smarter smarter deleted the dotty-staging:sbt-dotty-0.3.4 branch Aug 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.