Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IArray extension methods #7795

Merged
merged 12 commits into from Dec 29, 2019
Merged

IArray extension methods #7795

merged 12 commits into from Dec 29, 2019

Conversation

@brunnerant
Copy link
Contributor

brunnerant commented Dec 17, 2019

This is work in progress, it doesn't work yet (in particular, the test time out for some unknown reason).

@nicolasstucki nicolasstucki self-requested a review Dec 17, 2019
@brunnerant

This comment has been minimized.

Copy link
Contributor Author

brunnerant commented Dec 20, 2019

Should I copy all the documentation from ArrayOps.scala to the extension methods that I added ?

@nicolasstucki

This comment has been minimized.

Copy link
Contributor

nicolasstucki commented Dec 20, 2019

Yes, that would be great

@nicolasstucki

This comment has been minimized.

Copy link
Contributor

nicolasstucki commented Dec 20, 2019

BTW, #7806 will move the IArray file. This should in theory not be a conflict as it does not change its contents.

@nicolasstucki

This comment has been minimized.

Copy link
Contributor

nicolasstucki commented Dec 23, 2019

The code LGTM. Just missing the documentation.

@brunnerant

This comment has been minimized.

Copy link
Contributor Author

brunnerant commented Dec 23, 2019

Ok, I will do it as soon as possible !

@brunnerant

This comment has been minimized.

Copy link
Contributor Author

brunnerant commented Dec 25, 2019

I just copied the comments from ArrayOps.scala (in Scala 2). Note that I only took the short description of the methods, not the entire documentation about the parameters and the return value.

@nicolasstucki nicolasstucki marked this pull request as ready for review Dec 29, 2019
@nicolasstucki nicolasstucki merged commit 08f70cb into lampepfl:master Dec 29, 2019
2 checks passed
2 checks passed
CLA User signed CLA
Details
continuous-integration/drone/pr Build is passing
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.