Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7142: Detect scope extrusions in macros and run #8000

Merged
merged 2 commits into from Jan 23, 2020

Conversation

@nicolasstucki
Copy link
Contributor

nicolasstucki commented Jan 15, 2020

No description provided.

@nicolasstucki nicolasstucki self-assigned this Jan 15, 2020
@nicolasstucki nicolasstucki force-pushed the dotty-staging:fix-#7142 branch 9 times, most recently from e556af7 to 63abf80 Jan 15, 2020
@nicolasstucki nicolasstucki requested a review from liufengyun Jan 16, 2020
@nicolasstucki nicolasstucki force-pushed the dotty-staging:fix-#7142 branch from 63abf80 to 7831691 Jan 16, 2020
anatoliykmetyuk added a commit to dotty-staging/sourcecode that referenced this pull request Jan 17, 2020
In Scala 3, macro `mcr()` is expanded to:

  val macro$n = ...
  macro$n

Where n is an ordinal. This commit accounts for this change.
See lampepfl/dotty#8000.
@anatoliykmetyuk

This comment was marked as outdated.

Copy link
Contributor

anatoliykmetyuk commented Jan 17, 2020

You can point CI to this branch of sourcecode to make the test pass: https://github.com/dotty-staging/sourcecode/tree/dotty-pr-8000-adapt

When this PR is merged, we'll propagate that branch to the main branch and upstream.

@nicolasstucki nicolasstucki force-pushed the dotty-staging:fix-#7142 branch 2 times, most recently from b959904 to f1179cc Jan 20, 2020
nicolasstucki added a commit to dotty-staging/sourcecode that referenced this pull request Jan 20, 2020
In Scala 3, macro `mcr()` is expanded to:

  val macro$n = ...
  macro$n

Where n is an ordinal. This commit accounts for this change.
See lampepfl/dotty#8000.
@nicolasstucki nicolasstucki force-pushed the dotty-staging:fix-#7142 branch from f1179cc to 42cd971 Jan 20, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review Jan 20, 2020
@nicolasstucki nicolasstucki added this to the 0.22 Tech Preview milestone Jan 20, 2020
Copy link
Contributor

liufengyun left a comment

LGTM

This will improve debuggability thus meta-programming experience a lot 👍
I think it's much more usable than solutions based on type systems.

@nicolasstucki nicolasstucki merged commit b8d5be5 into lampepfl:master Jan 23, 2020
2 checks passed
2 checks passed
CLA User signed CLA
Details
continuous-integration/drone/pr Build is passing
Details
@nicolasstucki nicolasstucki deleted the dotty-staging:fix-#7142 branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.