Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port remaining Desugar and Applications errors to the new scheme #8263

Merged
merged 4 commits into from Feb 18, 2020

Conversation

@ausmarton
Copy link
Contributor

ausmarton commented Feb 9, 2020

As described in #1589
Tried porting a couple more of the Errors from Desugar. There are a couple more still remaining, but they seemed to take a bit longer to reproduce the errors for a minimal test case.

Copy link

dotty-bot left a comment

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@ausmarton ausmarton force-pushed the ausmarton:ticket/1589 branch 4 times, most recently from ba5f039 to 75224a5 Feb 9, 2020
@anatoliykmetyuk anatoliykmetyuk self-assigned this Feb 10, 2020
@anatoliykmetyuk anatoliykmetyuk self-requested a review Feb 10, 2020
@ausmarton ausmarton force-pushed the ausmarton:ticket/1589 branch 3 times, most recently from ac00dbb to e1edca9 Feb 10, 2020
@ausmarton ausmarton changed the title Port more Desugar errors to the new scheme Port more Desugar and Applications errors to the new scheme Feb 10, 2020
@ausmarton ausmarton force-pushed the ausmarton:ticket/1589 branch 5 times, most recently from 5df66aa to bbe845d Feb 11, 2020
@ausmarton

This comment has been minimized.

Copy link
Contributor Author

ausmarton commented Feb 16, 2020

Tried porting couple more error messages from Desugar, and came across a redundant check for extension methods being done in Parsers. I've removed the check from Parsers now as suggested by @smarter here: gitter.im/lampepfl/dotty?at=5e485ace0c50da598c1236e9
It seems like that has some implications on #6900

@ausmarton ausmarton requested a review from smarter Feb 16, 2020
@ausmarton ausmarton force-pushed the ausmarton:ticket/1589 branch 4 times, most recently from fb56784 to 24a8ba1 Feb 16, 2020
@ausmarton ausmarton changed the title Port more Desugar and Applications errors to the new scheme Port remaining Desugar and Applications errors to the new scheme Feb 17, 2020
@ausmarton ausmarton force-pushed the ausmarton:ticket/1589 branch 3 times, most recently from 0893738 to 7a3d106 Feb 17, 2020
@ausmarton

This comment has been minimized.

Copy link
Contributor Author

ausmarton commented Feb 17, 2020

All Desugar errors ported to the new scheme now.

I've noticed that for some reason, although the checks are successful, this page seems to show that the "continuous-integration/drone/pr" check is still not reported. In fact, the latest build here: https://dotty-ci.epfl.ch/lampepfl/dotty/4482 is successful.

@ausmarton ausmarton force-pushed the ausmarton:ticket/1589 branch 2 times, most recently from ebe8850 to 697f6e7 Feb 17, 2020
@ausmarton ausmarton force-pushed the ausmarton:ticket/1589 branch from 697f6e7 to 6caa732 Feb 17, 2020
Copy link
Contributor

anatoliykmetyuk left a comment

LGTM, thanks @ausmarton!

@anatoliykmetyuk anatoliykmetyuk merged commit 76caf35 into lampepfl:master Feb 18, 2020
3 checks passed
3 checks passed
test
Details
test_bootstrapped
Details
CLA User signed CLA
Details
@ausmarton ausmarton deleted the ausmarton:ticket/1589 branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.