Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8564: Make concrete inline methods final #8608

Merged
merged 4 commits into from Mar 31, 2020
Merged

Fix #8564: Make concrete inline methods final #8608

merged 4 commits into from Mar 31, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki marked this pull request as ready for review March 26, 2020 06:07
odersky
odersky requested changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to go back to the original commit

051039e

from #8543 that was retracted then and add the tests to that.

compiler/src/dotty/tools/dotc/ast/Desugar.scala Outdated Show resolved Hide resolved
compiler/src/dotty/tools/dotc/typer/RefChecks.scala Outdated Show resolved Hide resolved
compiler/src/dotty/tools/dotc/typer/RefChecks.scala Outdated Show resolved Hide resolved
@odersky odersky assigned nicolasstucki and unassigned odersky Mar 27, 2020
@odersky odersky merged commit 8a42819 into scala:master Mar 31, 2020
@odersky odersky deleted the fix-#8564 branch March 31, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolasstucki @odersky