New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auto tupling of function arguments #898

Merged
merged 7 commits into from Feb 18, 2016

Conversation

Projects
None yet
2 participants
@odersky
Contributor

odersky commented Oct 31, 2015

Based on #887. Implements SIP #897. Review by @retronym?

@odersky odersky force-pushed the dotty-staging:add/auto-uncurry branch from 0b87375 to 6a5f698 Nov 17, 2015

@odersky

This comment has been minimized.

Contributor

odersky commented Nov 17, 2015

@retronym Unfortunately your comments were eaten by the rebase. I got the comment about call-by-name parameters. Was there anything else I should look at?

@retronym

This comment has been minimized.

Contributor

retronym commented Nov 18, 2015

@odersky Can you find them in your email archives (search for "[dotty] Implement auto uncurry"). I don't get email notifications of my own comments, and I can't find them on commits in your previous branch, either: master...0b8737

@retronym

This comment has been minimized.

Contributor

retronym commented Nov 18, 2015

Oh, it looks like I made my comments on #897.

@odersky

This comment has been minimized.

Contributor

odersky commented Nov 18, 2015

Thanks for digging them out Jason! I'll remember the e-mail trick for next
time.

  • Martin

On Wed, Nov 18, 2015 at 5:06 AM, Jason Zaugg notifications@github.com
wrote:

Oh, it looks like I made my comments on #897
#897.


Reply to this email directly or view it on GitHub
#898 (comment).

Martin Odersky
EPFL

@odersky odersky changed the title from Implement auto uncurry to Implement auto tupling of function arguments Feb 16, 2016

odersky added some commits Oct 31, 2015

Add more pos and neg tests
Tests suggested by @retronym's comments on issue #897.
Strengthen requirement for auto-tupling
Was: corresponding parameter types "are compatible".
Now: corresponding parameter types "conform".

This avoids the inconsistency mentioned by @retronym in #897.
Untuple using `def` not `val`.
As retronym noted on #897, `val` forces to early.

@odersky odersky force-pushed the dotty-staging:add/auto-uncurry branch from 6a5f698 to 1729676 Feb 16, 2016

Fix pos test
Former test no longer allowed after conforms/compatible change.
@odersky

This comment has been minimized.

Contributor

odersky commented Feb 18, 2016

I don't think we see further reviewer comments. Merging.

odersky added a commit that referenced this pull request Feb 18, 2016

Merge pull request #898 from dotty-staging/add/auto-uncurry
Implement auto tupling of function arguments

@odersky odersky merged commit 0afccf5 into lampepfl:master Feb 18, 2016

4 checks passed

validate-junit [1075] SUCCESS. Took 21 min.
Details
validate-main [1087] SUCCESS. Took 27 min.
Details
validate-partest [1077] SUCCESS. Took 19 min.
Details
validate-partest-bootstrapped [169] SUCCESS. Took 20 min.
Details

@allanrenucci allanrenucci deleted the dotty-staging:add/auto-uncurry branch Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment