Re-resolve ==, != after expanding opaque types #9583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve overloading of `==` and `!=` after expanding opaque types. If we do not do that, all comparisons of opaque types will go to object equals, which involves boxing.
|
This was part of the performance optimizations batch. |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
liufengyun
approved these changes
Aug 19, 2020
| case _ => | ||
| tree | ||
| else | ||
| tree |
There was a problem hiding this comment.
It would be nice to restrict it to opaque types. Let's see how it impacts performance.
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9583/ to see the changes. Benchmarks is based on merging with master (64a239f) |
Also, document what is done in the doc page for opaque types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve overloading of
==and!=after expanding opaque types. Ifwe do not do that, all comparisons of opaque types will go to object
equals, which involves boxing. Since opaque types have a "no-boxing"
promise, this is problematic.