Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware Improvement #5

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@faabiosr
Copy link
Member

faabiosr commented Oct 7, 2019

No description provided.

The target will be used for development.
@faabiosr faabiosr force-pushed the faabiosr:master branch from 66e4f69 to b58d7b2 Oct 7, 2019
The middleware execution was changed to define a first handler to
call, this executor method is responsible to execute the handler
passing the necessary arguments to it.

For helping the execution was necessary to create auxiliar
interface like HandlerFunc and change the MiddlewareFunc.
@faabiosr faabiosr force-pushed the faabiosr:master branch from b58d7b2 to 6be8798 Oct 7, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #5 into master will decrease coverage by 0.6%.
The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   89.28%   88.67%   -0.61%     
==========================================
  Files           1        1              
  Lines          56       53       -3     
==========================================
- Hits           50       47       -3     
  Misses          3        3              
  Partials        3        3
Impacted Files Coverage Δ
commandbus.go 88.67% <82.75%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce7d9d...6be8798. Read the comment docs.

@vsmoraes vsmoraes merged commit 889cea6 into lana:master Oct 7, 2019
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 82.75% of diff hit (target 89.28%)
Details
codecov/project 88.67% (-0.61%) compared to 0ce7d9d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.