Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opencensus Middleware #7

Merged
merged 2 commits into from Oct 14, 2019

Conversation

@faabiosr
Copy link
Member

faabiosr commented Oct 13, 2019

Middleware for collecting metrics of command execution.

faabiosr added 2 commits Oct 13, 2019
Created tests for Logger middleware.
This middleware was created to collect metrics when a command is
executed.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 13, 2019

Codecov Report

Merging #7 into master will increase coverage by 6.7%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #7     +/-   ##
=========================================
+ Coverage   89.33%   96.03%   +6.7%     
=========================================
  Files           3        4      +1     
  Lines          75      101     +26     
=========================================
+ Hits           67       97     +30     
+ Misses          8        2      -6     
- Partials        0        2      +2
Impacted Files Coverage Δ
middleware/opencensus.go 84.61% <84.61%> (ø)
middleware/logger.go 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01f6f66...c54eca2. Read the comment docs.

@vsmoraes vsmoraes merged commit 82d53e4 into lana:master Oct 14, 2019
2 of 3 checks passed
2 of 3 checks passed
codecov/patch 84.61% of diff hit (target 89.33%)
Details
codecov/project 96.03% (+6.7%) compared to 01f6f66
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@faabiosr faabiosr deleted the faabiosr:opencensus branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.