Skip to content

ci: harden protoc install for Linux wheels#7149

Merged
Xuanwo merged 1 commit into
mainfrom
xuanwo/fix-python-arm-protoc
Jun 8, 2026
Merged

ci: harden protoc install for Linux wheels#7149
Xuanwo merged 1 commit into
mainfrom
xuanwo/fix-python-arm-protoc

Conversation

@Xuanwo

@Xuanwo Xuanwo commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

This PR hardens Linux wheel protoc setup after Python Linux 3.13 ARM failed on PR #7148 because the manylinux before-script downloaded an invalid /tmp/protoc.zip, unzip failed inside an && chain, and maturin-action continued until the Rust build could not find protoc.

The fix moves the protoc download into a small shared script that maps supported Linux architectures, retries invalid downloads, validates the archive with unzip -tq, and keeps the before-script commands separate under set -euo pipefail so setup failures stop the wheel build at the right point.

@github-actions github-actions Bot added A-ci CI / build workflows ci Github Action or Test issues labels Jun 8, 2026
@Xuanwo Xuanwo marked this pull request as ready for review June 8, 2026 15:34

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@Xuanwo Xuanwo merged commit 9cc9615 into main Jun 8, 2026
20 of 21 checks passed
@Xuanwo Xuanwo deleted the xuanwo/fix-python-arm-protoc branch June 8, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci CI / build workflows ci Github Action or Test issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants