feat(rust)!: use BoxedError in Error::IO

[broccoliSpicy]

Closes #2328

currently, lots of error in our codebase are wrapped in Error::IO, some are not accurate. like this one:
source example

            return Err(Error::IO {
                message: "HashJoiner: No data".to_string(),
                location: location!(),
            });

this PR still wraps this error in Error::IO, as we haven't define more precise Error type for HashJoiner yet.

we may need to define our own Error enum in each of our submodule, lance-encoding::Error, lance-file::Error, lance-index::Error etc.
so we can write error return like this:

            let err = lance_core::Error::from(lance::dataset::Error::HashJoinerError {
                message: "HashJoiner: No data".to_string(),
                location: location!(),
            });
            Err(err)

[github-actions]

ACTION NEEDED

Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

[wjones127]

I don't really see the point of creating lance-file::Error (and others) and wrapping it in Error::IO. The wrapping errors is more for wrapping our dependencies errors like those from Arrow, ObjectStore, and DataFusion.

[wjones127]

This is looking cleaner. Got two small suggestions and then I think this is ready to go :)

[wjones127]

I'd maybe go with ObjectStore::NotSupported here instead:

Suggested change

	// TODO: Check the correct way to construct a object_store::Error::Generic
	let err = lance_core::Error::from(object_store::Error::Generic {
	store: "",
	source: format!("Unsupported URI scheme: {}", unknow_scheme).into(),
	});
	let err = lance_core::Error::from(object_store::Error::NotSupported {
	source: format!("Unsupported URI scheme: {}", unknow_scheme).into(),
	});

[broccoliSpicy]

sorry, I forget this two TODO comments, it's removed now, thank you!

[wjones127]

I think you missed my actual change here, which is to use Error::NotSupported instead of Error::Generic for this spot. Same with the other comment.

[broccoliSpicy]

ha, I totally missed your comment, fixed.

[wjones127]

Same thing here:

Suggested change

	unknow_scheme => {
	// TODO: Check the correct way to construct a object_store::Error::Generic
	let err = lance_core::Error::from(object_store::Error::Generic {
	store: "",
	source: format!("Unsupported URI scheme: {}", unknow_scheme).into(),
	});
	Err(err)
	}
	unknown_scheme => {
	Err(lance_core::Error::from(object_store::Error::NotSupported {
	source: format!("Unsupported URI scheme: {}", unknown_scheme).into(),
	}))
	}

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 10.72089% with 483 lines in your changes are missing coverage. Please review.

Project coverage is 80.79%. Comparing base (711ac03) to head (4d1ae1a).

Files	Patch %	Lines
rust/lance-table/src/io/commit/dynamodb.rs	0.00%	69 Missing ⚠️
rust/lance/src/io/exec/planner.rs	0.00%	56 Missing and 1 partial ⚠️
rust/lance/src/dataset/scanner.rs	17.85%	42 Missing and 4 partials ⚠️
rust/lance/src/utils/tfrecord.rs	0.00%	29 Missing ⚠️
rust/lance/src/index/vector/ivf/io.rs	0.00%	28 Missing ⚠️
rust/lance-file/src/writer.rs	0.00%	19 Missing and 3 partials ⚠️
rust/lance/src/dataset/fragment.rs	29.62%	19 Missing ⚠️
rust/lance/src/io/exec/knn.rs	0.00%	16 Missing and 2 partials ⚠️
rust/lance/src/index/vector/ivf.rs	0.00%	15 Missing and 1 partial ⚠️
rust/lance-io/src/object_writer.rs	0.00%	10 Missing and 4 partials ⚠️
... and 24 more

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2329   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files         192      192           
  Lines       56213    56212    -1     
  Branches    56213    56212    -1     
=======================================
+ Hits        45416    45417    +1     
- Misses       8128     8137    +9     
+ Partials     2669     2658   -11     

Flag	Coverage Δ
unittests	80.79% <10.72%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wjones127]

@broccoliSpicy there seem to be some lint / syntax errors that need to be fixed.

[broccoliSpicy]

@broccoliSpicy there seem to be some lint / syntax errors that need to be fixed.

thank you so much @wjones127 ! fixed lint locally but I will see how github CI goes

[broccoliSpicy]

sorry this PR has awfully too many commits, I have issue with my local cargo fmt and kind of used github CI to manually fix lint a few times, I can do a force-push if that's needed