chore(python): add docstring for limit behavior #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
approved these changes
Jan 10, 2024
Comment on lines
+273
to
+276
| *WARNING* if you have a large dataset, removing | ||
| the limit can potentially result in reading a | ||
| large amount of data into memory and cause | ||
| out of memory issues. |
There was a problem hiding this comment.
Even if I call to_batches?
There was a problem hiding this comment.
we don't have to_batches api yet. I'll create a follow-up issue
python/lancedb/query.py
Outdated
|
|
||
| Returns | ||
| ------- | ||
| LanceQueryBuilder | ||
| The LanceQueryBuilder object. | ||
| """ | ||
| self._limit = limit | ||
| if limit is None or limit < 0: |
There was a problem hiding this comment.
made limit == 0 also act as if there's no limit
koolamusic
pushed a commit
to tecmie/lancedb
that referenced
this pull request
Jan 12, 2024
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
westonpace
pushed a commit
that referenced
this pull request
Apr 5, 2024
westonpace
pushed a commit
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #796