Add CarbonateProducer component #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregtucker
requested changes
Mar 19, 2021
There was a problem hiding this comment.
Looks great! Just a few things to tidy up. Happy to pitch in and take care of some/all of them, just ping me. (This is fun for me, as Bob A and I have for several years used this same function for a 1D carbonate modeling class exercise in GEOL 5775! Would be neat to share this 2+D component with the class next time we offer it, likely spring 2022)
gregtucker
previously approved these changes
Feb 11, 2022
|
@mcflugen do you have time to take a look at the added tests and tutorial? |
|
@gregtucker I'll have a look at it this afternoon. |
|
Looks good @gregtucker! Since I created the pull request, I can't provide an official review but if you think it's ready to go, I think it's ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new component, CarbonateProducer, that grows carbonate reefs in the ocean. It's not done yet but will be soon.