New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra "app" symlink showing up in project after a rebuild #1043

Closed
bmcclure opened this Issue Jun 13, 2018 · 7 comments

Comments

Projects
None yet
6 participants
@bmcclure
Copy link

bmcclure commented Jun 13, 2018

Bug Report

Tell us about your setup

v3.0.0-beta.47 on elementaryOS Loki

Tell us about your .lando.yml

name: mysite
recipe: pantheon
config:
  framework: drupal
  env: dev
  site: mysite
  id: c4d05745-2c4a-4127-9b54-2a09905a5292
  xdebug: true

pantheon.yml:

api_version: 1
php_version: 7.0
drush_version: 8

Tell us about the command you were running

lando rebuild -y

Tell us about the error you got

In this case, there is no error, but just an extra symlink showing up in the code.

Tell us generally about your bug

It seems like rebuilding the app as of one of the most recent Lando releases also adds a new "app" symlink to the code directory which points to /app. It shows up as a new file in the git repository and is easy to accidentally commit if you don't watch out for it. Deleting the file doesn't seem to break anything.

@jcandan

This comment has been minimized.

Copy link
Contributor

jcandan commented Jul 23, 2018

I see app -> /app as well, but not with a lando rebuild. It shows up after a lando pull for me.

@seanr

This comment has been minimized.

Copy link

seanr commented Aug 2, 2018

I see this on rebuild as well.

@neclimdul

This comment has been minimized.

Copy link
Contributor

neclimdul commented Aug 3, 2018

@seanr

This comment has been minimized.

Copy link

seanr commented Aug 6, 2018

@neclimdul Maybe to mimic the pantheon.yml behavior when you change the home directory? Probably best to just add it to the gitignore, then.

@truls1502

This comment has been minimized.

Copy link

truls1502 commented Aug 6, 2018

I can confirm @seanr 's comment where I have already added it to .gitignore and it works fine.

@bmcclure

This comment has been minimized.

Copy link
Author

bmcclure commented Aug 8, 2018

I'm not sure I understand the reasoning behind leaving this behavior in. This isn't really mimicking Pantheon's behavior, because you don't end up with an "app" symlink inside the code directory on Pantheon.

Yes, adding it to .gitignore works, but I am not in agreement about that being the best solution.

@pirog pirog self-assigned this Jan 13, 2019

@pirog pirog added this to the 3.0.0-rc.2 milestone Jan 13, 2019

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Jan 13, 2019

@bmcclure it mimics pantheons behavior because $HOME/code should point to your applications code, which is /app on lando.

The issue is basically symlink transitivity so it works fine the first time but subsequent times its resolving the /var/www/code to /app and you end up with /app -> /app.

That said this should be fixed in forthcoming rc2

@pirog pirog closed this Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment