New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message on poweroff #1097

Closed
lumpysimon opened this Issue Jul 11, 2018 · 6 comments

Comments

Projects
None yet
6 participants
@lumpysimon
Copy link

lumpysimon commented Jul 11, 2018

Every time I run the lando poweroff command I get the following warning message:

Spinning containers down... Standby.
(node:8594) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 
21 post-instantiate-app listeners added. 
Use emitter.setMaxListeners() to increase limit

The poweroff then completes successfully immediately afterwards, so it doesn't seem to be causing any serious failure.

Lando v3.0.0-beta.47
MacOS 10.13.5

@james-agile-coop

This comment has been minimized.

Copy link

james-agile-coop commented Oct 17, 2018

I get this too on v3.0.0-rc.1 and MacOS 10.13.4.

@tylerssn

This comment has been minimized.

Copy link

tylerssn commented Nov 7, 2018

Do you have any custom plugins in place? When developing plugins for Lando, I often have to tick Nodes max listeners +1 for each event listener that I add.

@lumpysimon

This comment has been minimized.

Copy link
Author

lumpysimon commented Nov 9, 2018

I'm using the default Lando installation for MacOS, I've not added any plugins.

@agilec-paul

This comment has been minimized.

Copy link

agilec-paul commented Nov 26, 2018

I also get this on lando poweroff

On Ubuntu 18.04
Lando v3.0.0-rc.1

@martin-klima

This comment has been minimized.

Copy link

martin-klima commented Dec 3, 2018

The same warning.
Linux Mint 18.2, Lando v3.0.0-rc.1

@pirog pirog self-assigned this Jan 13, 2019

@pirog pirog added this to the 3.0.0-rc.2 milestone Jan 13, 2019

pirog added a commit that referenced this issue Jan 13, 2019

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Jan 13, 2019

Warnings generally do not cause "serious failures" eg "fatal errors". I also think warnings will only surface if youve configured node to print warnings (which is not the default).

That said, we've bumped the max listeners to 64 in the forthcoming RC2 as that seems a more reasonable number esp if people are writing their own plugins

@pirog pirog closed this Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment