New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lando unable to pass through certain Drush commands with -- operator #1173

Closed
johnpez opened this Issue Sep 7, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@johnpez
Copy link

johnpez commented Sep 7, 2018

I'm using the Drupal 8 recipe of Lando v3.0.0-beta.47 on Mac OSX High Sierra 10.13.6

This is a very specific error, but I bet it affects a fair amount of people using Drupal with Lando.

Essentially, the Drush rsync command allows you to pass arguments after a " -- " character, for instance:

drush rsync @dev @prod -- --delete

Using the drush command through lando, arguments after the -- are either not recognized or not respected.

The easiest way to recreate:

From a Drupal8 Lando instance run: lando drush -s rsync a b -- --delete
The output will be: Calling system(rsync -e 'ssh ' -akz a b);

Then, do a lando ssh and run drush -s rsync a b -- --delete
The output will be: Calling system(rsync -e 'ssh ' -akz --delete --ansi a b);

Note that --delete only shows up when calling drush directly, not when calling it through lando.

Any thoughts on possible workarounds? Any more information I can provide? Please let me know and ty for lando!

@serundeputy

This comment has been minimized.

Copy link
Member

serundeputy commented Sep 10, 2018

yeah that is going to be in conflict with lando commands, i.e.:

lando drush cr -- -vvv

all the things after the -- are things that lando looks for so to get the drush stuff to work we'd have to implement some trickery.

I don't have any idea off the top of my head how to make the distinction between them.

@pirog pirog self-assigned this Jan 12, 2019

@pirog pirog added this to the 3.0.0-rc.2 milestone Jan 12, 2019

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Jan 12, 2019

@johnpez we've actually removed lando "global" options so this should be possible in the forthcoming rc2

@pirog pirog closed this Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment