New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Exclude functional tests from repository. Make test path to Lando bin absolute. #1296

Closed
tylerssn opened this Issue Nov 16, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@tylerssn
Copy link

tylerssn commented Nov 16, 2018

In PR #1246 you can see that my functional tests require executing Lando from various directories. The functional test generator expects the Lando command to be executed from within the app root and therefore replaces references to lando with node ../../bin/lando.js.

As you can see in the PR I was able to work around this by caching the path to Lando in a variable and working some bash magic, however, it overcomplicates the readme.md of the example and adds bash logic that is only relevant to the functional test, and not the greater Lando user base.

My proposal is:

  1. Because functional tests are recreated upon yarn test:functional that they be excluded from the repository.
  2. Replacing references to lando with node $absolutePath/bin/lando.js

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 27, 2018

pirog added a commit that referenced this issue Nov 29, 2018

@pirog pirog self-assigned this Jan 12, 2019

@pirog pirog added this to the 3.0.0-rc.2 milestone Jan 12, 2019

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Jan 12, 2019

@tylerssn we ended up following 1 in your list of proposals in our RC2 branch. We ended up spinning off the functional testing framework into another project called LEIA https://github.com/lando/leia which just assumes what you need is in PATH somewhere. This adds a little extra complexity in so far as the user needs to make sure the correct thing is being used EG the source version of lando being used instead of one provided by one of our installers but simplifies everything else quite a bit

@pirog pirog closed this Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment