New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST RC2 notes for Pirog #1375

Open
pirog opened this Issue Feb 1, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@pirog
Copy link
Member

pirog commented Feb 1, 2019

  • github release deploy weird for windows
  • get a better setup for windows dev
  • overrides normalize on windows
  • drush 9 on pantheon, status check fails
  • test NODE cert dir value
  • lando apache .htaccess file
  • --help and --version mess with shit (this seems to be upstream in YARGS)
  • note /var/www and named volume persistence
  • note build step failure
  • db-export does not gzip if arg ends in .gz
  • better document linux install
  • pantheon solr index needs help, requires a restart for index posting
  • add tests for pantheon ENV
  • note morehttpporrts
  • select properties in lando config, filters etc for lando list
  • GO BACK AND MAKE NODE better with ssl eg a porthttps property
  • add port to dotnet just like with python/node/ruby etc
  • ALIASES need to be service specific FPM and MAILHOG, we do this in varnish
  • vhost custom for php
  • can we set server and/or vhosts in LAMPy recipe config?
  • mssql database available for things?
  • nginx/apache caching issue re: js/css/etc max expiration?
  • sort global help options? just the global ones now
  • redo pantheon index and appserver as separate service?
  • custom localtunnel instance

@pirog pirog added this to the 3.0.0-rc.3 milestone Feb 1, 2019

@pirog pirog self-assigned this Feb 1, 2019

pirog added a commit that referenced this issue Feb 2, 2019

pirog added a commit that referenced this issue Feb 2, 2019

@pirog pirog removed this from the 3.0.0-rc.3 milestone Feb 2, 2019

@wss-chadical

This comment has been minimized.

Copy link

wss-chadical commented Feb 3, 2019

@pirog "mssql database available for things?"
"Available" as in pulling a database from pantheon during a build step in the appserver?
Database service used to be available during appserver build in RC1....

@pirog

This comment has been minimized.

Copy link
Member Author

pirog commented Feb 3, 2019

@wss-chadical

This comment has been minimized.

Copy link

wss-chadical commented Feb 4, 2019

@pirog "mssql database available for things?"
"Available" as in pulling a database from pantheon during a build step in the appserver?
Database service used to be available during appserver build in RC1....

Yeah, now that I re-read it, I was thinking mysql. I will open an issue for the lack of "depends_on: -database" for the appserver service in the pantheon recipe.

@pirog

This comment has been minimized.

Copy link
Member Author

pirog commented Feb 4, 2019

@wss-chadical check out the latest docs on build steps
https://docs.devwithlando.io/config/services.html#build-steps

Note that build and build_as_root now run before your app starts. run and run_as_root run after your app has started. This means that if you have a build step that requires a service outside of the service you are running a pre-start build step on to be up you need to use run or run_as_root

aka this is not a bug but a change in config

@pirog pirog added this to the 3.0.0-rc.4-HOTFIXEZ milestone Feb 4, 2019

@wss-chadical

This comment has been minimized.

Copy link

wss-chadical commented Feb 4, 2019

@pirog
"Note that build steps will ONLY RUN THE FIRST TIME YOU SPIN UP YOUR APP. That means that if you change them you will need to run lando rebuild for them to re-run."

Got it.

@pirog pirog removed this from the 3.0.0-rc.4-HOTFIXEZ milestone Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment