New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LANDO_INFO has lost service names and instead has integers as array keys #1376

Closed
hkirsman opened this Issue Feb 1, 2019 · 6 comments

Comments

Projects
None yet
2 participants
@hkirsman
Copy link

hkirsman commented Feb 1, 2019

When changing to v3.0.0-rc.2 I had to change the lando info a bit to make Drupal work:

-    'database' => $lando_info['database']['creds']['database'],
-    'username' => $lando_info['database']['creds']['user'],
-    'password' => $lando_info['database']['creds']['password'],
-    'host' => $lando_info['database']['internal_connection']['host'],
-    'port' => $lando_info['database']['internal_connection']['port'],
+    'database' => $lando_info[2]['creds']['database'],
+    'username' => $lando_info[2]['creds']['user'],
+    'password' => $lando_info[2]['creds']['password'],
+    'host' => $lando_info[2]['internal_connection']['host'],
+    'port' => $lando_info[2]['internal_connection']['port'],

I think the keys should still be service names as the integers might change.

This is my .lando.yml:

name: drupal7.benchmark
recipe: drupal7
config:
  php: '7.0'
  via: nginx:1.14
  database: mariadb:10.1

@hkirsman hkirsman added the bug label Feb 1, 2019

@hkirsman hkirsman changed the title LANDO_INFO has lost service names and instead has integers LANDO_INFO has lost service names and instead has integers as array keys Feb 1, 2019

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Feb 1, 2019

makes sense, we changed info to an array of objects instead of an object.

Only question now is whether we want to document this change or change it back to the way it was before

@pirog pirog added this to the 3.0.0-rc.3 milestone Feb 1, 2019

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Feb 2, 2019

Ok yeah @hkirsman i think i agree with you that this needs to stay the same

@pirog pirog self-assigned this Feb 2, 2019

pirog added a commit that referenced this issue Feb 2, 2019

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Feb 2, 2019

ok @hkirsman ive fixed this in master

@pirog pirog closed this Feb 2, 2019

@hkirsman

This comment has been minimized.

Copy link
Author

hkirsman commented Feb 2, 2019

Tx! What's the plan for this fix? Will there be soon small update for current release?

@pirog

@hkirsman

This comment has been minimized.

Copy link
Author

hkirsman commented Feb 2, 2019

Cool, you already did release. Will be testing.

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Feb 2, 2019

yeah we are going to be pushing releases pretty often here on out esp for obvious regressions. its a priority for us to get as many users onto rc.2+ as fast as possible and that means releasing often

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment