New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling command doubled when failure exit code returned #1378

Closed
westonruter opened this Issue Feb 1, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@westonruter
Copy link

westonruter commented Feb 1, 2019

Something strange I'm noticing in regards to tooling: in my .lando.yml I have:

tooling:
# ...
  phpunit:
    service: appserver

When I run lando phpunit and all assertions pass, then the command is just run once:

image

But if there was a test failure, then the phpunit command runs a second time:

image

It's unexpected that a command returning a failing exit code would be executed twice.

This didn't happen in 3rc1.

I'm running v3.0.0-rc.2 on MacOS 10.14.2.

Ref Slack convo: https://kalabox.slack.com/archives/C5Q6XTY3S/p1549059456816400

@westonruter westonruter added the bug label Feb 1, 2019

@pirog pirog self-assigned this Feb 2, 2019

@pirog pirog added this to the 3.0.0-rc.3 milestone Feb 2, 2019

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Feb 2, 2019

@westonruter ok this should be fixed in master!

pirog added a commit that referenced this issue Feb 2, 2019

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Feb 2, 2019

@westonruter pending tests passing anyway ;)

pirog added a commit that referenced this issue Feb 2, 2019

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Feb 2, 2019

Alright alright alright this is in it to win it

@pirog pirog closed this Feb 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment