Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.js is missing require('path') #1571

Closed
jnous opened this issue Apr 5, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@jnous
Copy link

commented Apr 5, 2019

I was experimenting with using a custom Docker host with lando, and ran into issue as I had to set certPath in ~/.lando/config.yml.

I get ReferenceError: path is not defined, and it looks to me like it is simply because lib/config.js does not require path, so maybe this could be fixed with simply adding const path = require('path'); at the top? Setting the engineConfig.ca etc. uses path.join() when engineConfig.certPath is defined, so the error won't be hit "in normal circumstances".

I know the remote Docker hosts are an unsupported feature, but the error is simple enough, I think.

@jnous jnous added the bug label Apr 5, 2019

@stale

This comment has been minimized.

Copy link

commented May 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.

@stale stale bot added the wontfix label May 5, 2019

@pirog pirog removed the wontfix label May 7, 2019

@pirog pirog self-assigned this May 8, 2019

@pirog pirog added this to the 3.0.0-rc.16 milestone May 8, 2019

@pirog

This comment has been minimized.

Copy link
Member

commented May 9, 2019

ahh nice catch @jnous, definitely a bug and likely a regression from our big RC2 refactor

pirog added a commit that referenced this issue May 9, 2019

@pirog pirog closed this May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.