Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails when vm.max_map_count doesn't exist #1586

Closed
w-biggs opened this issue Apr 12, 2019 · 1 comment · Fixed by #1587
Closed

Installation fails when vm.max_map_count doesn't exist #1586

w-biggs opened this issue Apr 12, 2019 · 1 comment · Fixed by #1587
Assignees
Labels
bug Something aint working right!
Milestone

Comments

@w-biggs
Copy link
Contributor

w-biggs commented Apr 12, 2019

Tell us about your setup

v3.0.0-rc.14 on WSL - Ubuntu 18.04.1 LTS.

Tell us about the command you were running

sudo dpkg -i lando-v3.0.0-rc.14.deb

Tell us about the error you got

sysctl: cannot stat /proc/sys/vm/max_map_count: No such file or directory

Max_map_count doesn't exist in WSL - they haven't implemented a dummy version of it like they have with some other /proc/sys/ files.

Tell us more

Wrapping this line in an if statement that checks whether /proc/sys/vm/max_map_count exists fixes the issue and allows Lando to be installed in WSL:

sysctl -w vm.max_map_count=262144

if [ -f /proc/sys/vm/max_map_count ]; then
  sysctl -w vm.max_map_count=262144
fi

I've confirmed this works and Lando properly installs. I'll submit a pull request with this change.

@w-biggs w-biggs added the bug Something aint working right! label Apr 12, 2019
@pirog
Copy link
Sponsor Member

pirog commented May 8, 2019

@w-biggs nice. sorry for the delay here but this seems like a completely reasonable and good change to me. Will def merge it in!

pirog added a commit that referenced this issue May 8, 2019
#1586: ONLY ATTEMPT TO BUMP MAX_MAP_COUNT IF MAX_MAP_COUNT EXISTS
@pirog pirog added this to the 3.0.0-rc.16 milestone May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something aint working right!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants