Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Support php 7.3 for pantheon recipe #1595
Lando >= v3.0.0-rc.13 supports PHP 7.3 (#1342), and Pantheon now forces PHP 7.3 on their upstream config, but the docker manifest for
The suggested fix is to add the missing configuration to the manifest.
Tell us about your setup
Lando v3.0.0-rc.15 on macOS 10.14.4
Tell us about your
name: REDACTED recipe: pantheon config: framework: wordpress env: dev site: REDACTED id: REDACTED index: false edge: false cache: false xdebug: true
api_version: 1 php_version: 7.3
Tell us about the command you were running
# Edited my pantheon.yml as above lando rebuild -y
Tell us about the error you got
This error is returned when
# ... Pulling appserver (devwithlando/pantheon-appserver:7.3-2)... ERROR: manifest for devwithlando/pantheon-appserver:7.3-2 not found # ...
A dirty fix in the interim is to set your PHP version to 7.2 in pantheon.yml and rebuild.
Done. Works. Thank you.
** Parden my ignorance, but would pushing up the pantheon upstream with php 7.2 cause problems on dev/test? Or should this just be edited to work with locally until there's an official fix?
I mean, I'm assuming you ran into this because Pantheon just pushed out 7.3 automatically to D8 and WordPress. If you didn't have a pantheon.yml already you would have been on PHP 7.2 prior to this AFAIK. From that perspective I don't know that it would cause any issues.
You should also revert the upstream to 7.2 until there is a fix or avoid any 7.3 code.
That didn't work for me, and I didn't expect that to work because that's only makes 7.2 version available, if you try to use some 7.3 feature then you're screwed.
Please, can someone add the missing manifest as @jakebellacera suggested?