Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support php 7.3 for pantheon recipe #1595

Closed
jakebellacera opened this issue Apr 25, 2019 · 9 comments

Comments

Projects
None yet
8 participants
@jakebellacera
Copy link
Contributor

commented Apr 25, 2019

Issue overview

Lando >= v3.0.0-rc.13 supports PHP 7.3 (#1342), and Pantheon now forces PHP 7.3 on their upstream config, but the docker manifest for devwithlando/pantheon-appserver:7.3-2 does not exist.

The suggested fix is to add the missing configuration to the manifest.

Debug info

Tell us about your setup

Lando v3.0.0-rc.15 on macOS 10.14.4

Tell us about your .lando.yml

.lando.yml

name: REDACTED
recipe: pantheon
config:
  framework: wordpress
  env: dev
  site: REDACTED
  id: REDACTED
  index: false
  edge: false
  cache: false
  xdebug: true

pantheon.upstream.yml

api_version: 1
php_version: 7.3

Tell us about the command you were running

# Edited my pantheon.yml as above
lando rebuild -y

Tell us about the error you got

This error is returned when lando rebuild -y is ran:

# ...
Pulling appserver (devwithlando/pantheon-appserver:7.3-2)...
ERROR: manifest for devwithlando/pantheon-appserver:7.3-2 not found
# ...

@jakebellacera jakebellacera added the bug label Apr 25, 2019

@gwixted

This comment has been minimized.

Copy link

commented Apr 29, 2019

Having the same issue.

@ekmoreau

This comment has been minimized.

Copy link

commented Apr 29, 2019

I'm having the same issue as well.

@jackfoust

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

A dirty fix in the interim is to set your PHP version to 7.2 in pantheon.yml and rebuild.

https://docs.devwithlando.io/tutorials/pantheon.html#choosing-a-php-version

@ekmoreau

This comment has been minimized.

Copy link

commented Apr 29, 2019

A dirty fix in the interim is to set your PHP version to 7.2 in pantheon.yml and rebuild.

https://docs.devwithlando.io/tutorials/pantheon.html#choosing-a-php-version

Done. Works. Thank you.

** Parden my ignorance, but would pushing up the pantheon upstream with php 7.2 cause problems on dev/test? Or should this just be edited to work with locally until there's an official fix?

@jackfoust

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

I mean, I'm assuming you ran into this because Pantheon just pushed out 7.3 automatically to D8 and WordPress. If you didn't have a pantheon.yml already you would have been on PHP 7.2 prior to this AFAIK. From that perspective I don't know that it would cause any issues.

@ericstroo

This comment has been minimized.

Copy link

commented Apr 30, 2019

A dirty fix in the interim is to set your PHP version to 7.2 in pantheon.yml and rebuild.
https://docs.devwithlando.io/tutorials/pantheon.html#choosing-a-php-version

Done. Works. Thank you.

** Parden my ignorance, but would pushing up the pantheon upstream with php 7.2 cause problems on dev/test? Or should this just be edited to work with locally until there's an official fix?

You should also revert the upstream to 7.2 until there is a fix or avoid any 7.3 code.

@Javiani

This comment has been minimized.

Copy link

commented May 5, 2019

A dirty fix in the interim is to set your PHP version to 7.2 in pantheon.yml and rebuild.

https://docs.devwithlando.io/tutorials/pantheon.html#choosing-a-php-version

That didn't work for me, and I didn't expect that to work because that's only makes 7.2 version available, if you try to use some 7.3 feature then you're screwed.

Please, can someone add the missing manifest as @jakebellacera suggested?
I need to use HEREDOC without the annoying indentation issues, and that's change completely how we're gonna work with components in this project we're gonna start in few days.

Thanks!

@audvin

This comment has been minimized.

Copy link

commented May 7, 2019

Setting php_version: 7.2 in pantheon.yml made Lando start without crashing, did not rebuild.

@pirog

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Hey all, we are going to push up an image for pantheon 7.3 in a bit.

Generally we are pretty good at being proactive with upcoming Pantheon changes but definitely had a communication breakdown with them on this one.

@pirog pirog self-assigned this May 7, 2019

@pirog pirog added this to the 3.0.0-rc.16 milestone May 7, 2019

pirog added a commit that referenced this issue May 7, 2019

pirog added a commit that referenced this issue May 7, 2019

pirog added a commit that referenced this issue May 8, 2019

pirog added a commit that referenced this issue May 8, 2019

@pirog pirog assigned pirog and unassigned pirog May 8, 2019

@pirog pirog closed this May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.