New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recoverable fatal error after switching to php 7.2 #747

Closed
robbdavis opened this Issue Mar 9, 2018 · 29 comments

Comments

Projects
None yet
10 participants
@robbdavis
Copy link

robbdavis commented Mar 9, 2018

My set up
v3.0.0-beta.35 - Mac OS - Sierra

My .lando.yml
Pantheon recipe - drupal8 framework

After switching to PHP 7.2 I'm getting the following error:

PHP Recoverable fatal error: PHP Startup: Cannot set 'user' save handler by ini_set() or session_module_name() in Unknown on line 0

I've switched back to php 7.1 and the error goes away. Drupal is recommending php7.2 now for version 8.5 so this is probably an issue that will become more common as people try updating.

@dustinleblanc dustinleblanc added pantheon and removed pantheon labels Mar 14, 2018

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Mar 15, 2018

@robbdavis is this a problem with lando iself? seems like this is something triggered by your app's code?

@dustinleblanc thoughts here?

@robbdavis

This comment has been minimized.

Copy link
Author

robbdavis commented Mar 16, 2018

The app is Drupal 8.5. It runs fine on php7.1 but throws this error with php7.2. I also didn't see any errors when I ran the same codebase on Pantheon using php7.2. That said, maybe I didn't look hard enough. When I get a chance, I'll do some tests again with php7.2 and re-check the pantheon logs.

@dustinleblanc

This comment has been minimized.

Copy link
Member

dustinleblanc commented Mar 18, 2018

I'll test this out @pirog. However, Its not an error I see on Pantheon, so I'd imagine if I can repro, we have something goofy going on here.

Google brought this up in a search https://github.com/php/php-src/blob/master/ext/session/tests/session_set_save_handler_class_014.phpt

@dustinleblanc

This comment has been minimized.

Copy link
Member

dustinleblanc commented Mar 18, 2018

Can confirm this happens when altering the php value in pantheon.yml:

image

@dustinleblanc

This comment has been minimized.

Copy link
Member

dustinleblanc commented Mar 18, 2018

I can confirm this doesn't happen in Drupal 8 recipe

@dustinleblanc dustinleblanc added the bug label Mar 18, 2018

@pirog pirog added this to the 3.0.0-beta.37 milestone Mar 19, 2018

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Mar 19, 2018

@robbdavis @dustinleblanc i suspect this is because the pantheon php image is still on an older version of php (eg 7.2.1). I'm going to rebase the images and im guessing that might eb sufficient to close this out.

@robbdavis

This comment has been minimized.

Copy link
Author

robbdavis commented Mar 20, 2018

Thanks for hunting this down @dustinleblanc and @pirog!

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Mar 20, 2018

@dustinleblanc if you can confirm a lando rebuild updates to the latest 7.2.3 then feel free to close this out

@dustinleblanc

This comment has been minimized.

Copy link
Member

dustinleblanc commented Mar 20, 2018

@pirog not working on my latest pull of master. still causing the same error to dump to stderr/stdout but it does update to 7.2.3

Setting up client key /lando/keys/pantheon/bethanys-art-shop/index.pem
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 4454k  100 4454k    0     0  2275k      0  0:00:01  0:00:01 --:--:-- 2275k
PHP Recoverable fatal error:  PHP Startup: Cannot set 'user' save handler by ini_set() or session_module_name() in Unknown on line 0
OS:	Linux 4.9.60-linuxkit-aufs #1 SMP Mon Nov 6 16:00:12 UTC 2017 x86_64
Shell:
PHP binary:	/usr/local/bin/php
PHP version:	7.2.3
php.ini used:
WP-CLI root dir:	phar://wp-cli.phar
WP-CLI vendor dir:	phar://wp-cli.phar/vendor
WP_CLI phar path:	/tmp
WP-CLI packages dir:
WP-CLI global config:
WP-CLI project config:
WP-CLI version:	1.5.0
/bin/sh: 1: drush: not found
error: Looks like one of your build steps failed...
warn: This **MAY** prevent your app from working
warn: Check for errors above, fix them, and try again
@pirog

This comment has been minimized.

Copy link
Member

pirog commented Mar 20, 2018

you might need to lando rebuild since i just updated the images for master

@pirog pirog modified the milestones: 3.0.0-beta.37, 3.0.0-beta.38 Mar 21, 2018

@dustinleblanc

This comment has been minimized.

Copy link
Member

dustinleblanc commented Mar 21, 2018

rebuilding off master this morning

@dustinleblanc

This comment has been minimized.

Copy link
Member

dustinleblanc commented Mar 21, 2018

I am starting on #742 and I think I can lump this in there with it as I will be mucking with the recipe

@shaal

This comment has been minimized.

Copy link
Contributor

shaal commented Mar 27, 2018

Same here, running lando35, Drupal 8.5, with pantheon recipe.
Got that error as above.

After I updated pantheon.yml to php7.1 and set composer.json to use PHP 7.1, the error disappeared and it's working without an error.

@mmwebaze

This comment has been minimized.

Copy link

mmwebaze commented Mar 28, 2018

I am getting the same error with lando v3.0.0-beta.35, Drupal 8.5 and pantheon recipe

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Mar 28, 2018

We are definitely working on this but it's also worth mentioning that you SHOULD be able to safely ignore this reported error

@pirog pirog modified the milestones: 3.0.0-beta.38, 3.0.0-beta.39 Mar 30, 2018

@dustinleblanc

This comment has been minimized.

Copy link
Member

dustinleblanc commented Mar 30, 2018

This is reproducible on Pantheon with PHP 7.2. At this point, I am going to call this an upstream bug, no fix from Lando. We simply surface the bug.

@truls1502

This comment has been minimized.

Copy link

truls1502 commented Jun 28, 2018

I still face it, it would be good to resolve the issue if it is possible. It is annoying for us who got such messages when we have upgraded PHP to 7.2

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Jun 28, 2018

I think there are more pressing issues to deal with than a recoverable fatal error that happens on one php version of one recipe that happens to "annoy" you.

@truls1502

This comment has been minimized.

Copy link

truls1502 commented Jun 28, 2018

I understand you @pirog - but would it not be a good idea to post a known issue on https://docs.devwithlando.io/services/php.html regarding with the Pantheon recipe? So it can help the developers with less of a waste of the time to troubleshoot for this one issue. 😊

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Jun 28, 2018

@truls1502

This comment has been minimized.

Copy link

truls1502 commented Jul 3, 2018

I still keep getting the error such as:
PHP Recoverable fatal error: PHP Startup: Cannot set 'user' save handler by ini_set() or session_module_name() in Unknown on line 0

Could anyone help me to point out what the problem with it is?

@alphex

This comment has been minimized.

Copy link

alphex commented Jul 7, 2018

@truls1502 read this thread - its a non error, error... more annoying than anything else.

@robbdavis

This comment has been minimized.

Copy link
Author

robbdavis commented Jul 7, 2018

I've learned to just live with it but "it's just annoying so leave it" isn't really a good approach. It is very annoying; it pops up twice every singe time I run a drush command.

Have we determined it is coming from Pantheon? If someone gives me some details on how/why this is coming from Pantheon, I'll contact them.

All that said, version v3.0.0-beta.47 has been otherwise running flawlessly for me so I'm not complaining!

@pirog

This comment has been minimized.

Copy link
Member

pirog commented Jul 9, 2018

@robbdavis to be fair, im not sure anyone here is legitimately advocating "it's just annoying so leave it" as the approach. Seems like the summary of this thread is essentially:

  1. This is an upstream issue that also exists on Pantheon (although its harder to spot because you dont really see the logs like you do in lando) so while its something that could be fixed in Lando its probably better if its addressed on Pantheon first and then rolled into lando
  2. There are other this-is-blocking-my-dev problems with Lando that are higher priority than this issue which while "annoying" is not really a show stopper.

I also dont think anyone is suggesting this get filed as "will not fix"

@dustinleblanc dustinleblanc removed the wontfix label Jul 9, 2018

@aekong

This comment has been minimized.

Copy link

aekong commented Aug 17, 2018

i'm having problems running phpunit i think because of this exception. phpunit catches it and errors out my very simple test.

@dustinleblanc

This comment has been minimized.

Copy link
Member

dustinleblanc commented Aug 30, 2018

Just dropping a note here from today's slack convo, this is still occasionally getting thrown on Pantheon too, so still considered an upstream bug

@colinlord

This comment has been minimized.

Copy link

colinlord commented Sep 4, 2018

Just chiming in to say that I'm also experiencing this same error like others have documented above.

@amklose

This comment has been minimized.

Copy link

amklose commented Sep 6, 2018

I realize it's not a critical issue but I just want to report that I'm getting the error on a Pantheon wordpress site as well, which would make sense since it's also using the pantheon recipe with php 7.2.

@lando lando locked as resolved and limited conversation to collaborators Sep 6, 2018

@dustinleblanc

This comment has been minimized.

Copy link
Member

dustinleblanc commented Sep 6, 2018

Going to go ahead and lock conversation on this, we already have this identified as an upstream bug, if anyone wants to chime in on it, jump on over to slack.

@dustinleblanc dustinleblanc modified the milestones: 3.0.0-beta.40, RC2 Nov 16, 2018

@dustinleblanc dustinleblanc reopened this Nov 16, 2018

@pirog pirog removed this from the RC1 milestone Nov 28, 2018

@pirog pirog added this to the 3.0.0-rc.2 milestone Jan 28, 2019

@pirog pirog closed this Jan 28, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.