New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lando init non-interactive breaks if you have a space in 'name' #891

Closed
geerlingguy opened this Issue Apr 11, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@geerlingguy

geerlingguy commented Apr 11, 2018

Bug Report

Lando v3.0.0-beta40 on macOS High Sierra

When I run the command:

lando init --recipe drupal8 --webroot "." --name "Drupal Lando" --yes

It creates a .lando.yml file with the following contents:

name: Drupal Lando
recipe: drupal8
config:
  webroot: .

When I run lando start, I get the following:

$ lando start -vvvv
landoproxyhyperion5000gandalfedition_proxy_1 is up-to-date
Creating drupallando_appserver_1 ... done
Creating drupallando_database_1  ... done
error: Looks like one of your build steps failed...
warn: This **MAY** prevent your app from working
warn: Check for errors above, fix them, and try again

BOOMSHAKALAKA!!!

Your app has started up correctly.
Here are some vitals:

 NAME      drupal lando
 LOCATION  /Users/jgeerling/Dropbox/Development/GitHub/drupal-the-fastest/methods/drupal-lando
 SERVICES  appserver, database

If I use the interactive lando init, and fill in the name "Drupal Lando", I notice the generated YAML file has name: drupal-lando.

So it looks like if we pass in a name that's not machine-name formatted non-interactively... it should be reformatted to a machine name before writing out to the Lando YAML file.

serundeputy added a commit that referenced this issue Apr 11, 2018

@serundeputy

This comment has been minimized.

Member

serundeputy commented Apr 11, 2018

PR: #892

@serundeputy serundeputy added the bug label Apr 11, 2018

@serundeputy serundeputy self-assigned this Apr 11, 2018

@serundeputy serundeputy added this to the 3.0.0-beta.41 milestone Apr 11, 2018

dustinleblanc added a commit that referenced this issue Apr 13, 2018

Merge pull request #892 from lando/891/machine-name
#891: Add kebabCase for option specified app name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment