New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Status API usage #108

Closed
carlio opened this Issue Feb 5, 2015 · 15 comments

Comments

Projects
None yet
@carlio
Copy link
Member

carlio commented Feb 5, 2015

GitHub has a status API which is the nice box saying "build failed because of tool X". Landscape should use that! See also #71

@raghavrv

This comment has been minimized.

Copy link

raghavrv commented Feb 17, 2015

👍

1 similar comment
@tofu-rocketry

This comment has been minimized.

Copy link

tofu-rocketry commented Feb 23, 2015

👍

@tilgovi

This comment has been minimized.

Copy link

tilgovi commented Mar 18, 2015

My ideal use of this would involve setting a threshold for score decrease to trigger a fail.

@tofu-rocketry

This comment has been minimized.

Copy link

tofu-rocketry commented Mar 19, 2015

I think a threshold would a nice additional feature, but, for me, any decrease in quality should be marked as a failure. One can still go ahead and merge a PR with a failed test after judging its possible impact.

@tilgovi

This comment has been minimized.

Copy link

tilgovi commented Mar 19, 2015

Truth. Sorry to complicate things. Just posting the status API would be amazing.

@nijel

This comment has been minimized.

Copy link

nijel commented Mar 27, 2015

👍

@krmaxwell

This comment has been minimized.

Copy link

krmaxwell commented Apr 1, 2015

This would be much better than the current commenting, for sure.

@amueller

This comment has been minimized.

Copy link

amueller commented Apr 6, 2015

+10

@dopplershift

This comment has been minimized.

Copy link

dopplershift commented Apr 28, 2015

+1

@public

This comment has been minimized.

Copy link

public commented Apr 30, 2015

+💯

@d0ugal

This comment has been minimized.

Copy link

d0ugal commented May 7, 2015

Yeah, I tried the commenting on PR's for a while, but it started to drive me mad. So had to disable it :(

@jakirkham

This comment has been minimized.

Copy link

jakirkham commented May 29, 2015

+1

@carlio

This comment has been minimized.

Copy link
Member Author

carlio commented Nov 29, 2015

Just released this, from now on it will use the Status API. Comments are now disabled, although you can re-enable them if you like (useful if you want to keep track of changes throughout a PR, as the status is only the "most recent" commit). Let me know if you notice any issues or if it is not updating or anything, cheers!

@carlio carlio closed this Nov 29, 2015

@jakirkham

This comment has been minimized.

Copy link

jakirkham commented Nov 29, 2015

Yay! Thanks @carlio. Looking forward to trying this.

@krmaxwell

This comment has been minimized.

Copy link

krmaxwell commented Nov 29, 2015

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment