New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request improvements #160

Closed
lukeyeager opened this Issue Jun 6, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@lukeyeager
Copy link

lukeyeager commented Jun 6, 2015

Pull request support is currently experimental. If you notice any problems please report them to the issue tracker.

I'm trying to merge this branch (Landscape) into this branch (Landscape) using this pull request, but I don't see anything triggered here. Am I missing something?

@lukeyeager

This comment has been minimized.

Copy link
Author

lukeyeager commented Jun 6, 2015

Oh wait, now it commented on my pull request. Two suggestions:

  1. Do "checks" rather than "comments" - #158.
  2. Show me that Landscape is working on pull requests like Travis does.

Thanks for the cool plugin!

@lukeyeager lukeyeager changed the title Pull Request check not triggering Pull request improvements Jun 6, 2015

@jhamman

This comment has been minimized.

Copy link

jhamman commented Oct 1, 2015

👍

@carlio

This comment has been minimized.

Copy link
Member

carlio commented Nov 29, 2015

Just released this, from now on it will use the Status API. Comments are now disabled, although you can re-enable them if you like (useful if you want to keep track of changes throughout a PR, as the status is only the "most recent" commit). Let me know if you notice any issues or if it is not updating or anything, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment