Activemodel 3.1, Validation fixes and Callback fixes #45

Merged
merged 13 commits into from Nov 8, 2011

Projects

None yet

2 participants

@jweiss

These commits include the following:

  • fix validation callback order

  • Handle returns from callbacks correctly.

    When a before save/create/update or before validations callback returns
    false, the filter chain is halted and the given block will not be
    called. This resulted in save operations happening although errors were
    present.

    Now the return value of all callbacks is checked and the save/update
    methods will abort and return false if a filter halted the chain.

  • remove validatable

@jweiss

Please also see 85318a2

@langalex langalex merged commit 85318a2 into langalex:master Nov 8, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment