From b8eed82668d7b58d2de22ae5675050a927b7c470 Mon Sep 17 00:00:00 2001 From: Sydney Runkle Date: Wed, 19 Nov 2025 09:25:12 -0500 Subject: [PATCH 1/2] use override not direct attribute assignment --- src/oss/langchain/agents.mdx | 2 +- src/oss/python/releases/langchain-v1.mdx | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/oss/langchain/agents.mdx b/src/oss/langchain/agents.mdx index 42f75663e2..33e3bdcfe8 100644 --- a/src/oss/langchain/agents.mdx +++ b/src/oss/langchain/agents.mdx @@ -163,7 +163,7 @@ def dynamic_model_selection(request: ModelRequest, handler) -> ModelResponse: else: model = basic_model - request.model = model + request = request.override(model=model) return handler(request) agent = create_agent( diff --git a/src/oss/python/releases/langchain-v1.mdx b/src/oss/python/releases/langchain-v1.mdx index a0fb2120d7..339d777d53 100644 --- a/src/oss/python/releases/langchain-v1.mdx +++ b/src/oss/python/releases/langchain-v1.mdx @@ -173,8 +173,7 @@ class ExpertiseBasedToolMiddleware(AgentMiddleware): model = ChatOpenAI(model="gpt-5-nano") tools = [simple_search, basic_calculator] - request.model = model - request.tools = tools + request = request.override(model=model, tools=tools) return handler(request) agent = create_agent( From 849e04eca06df03ffaf9896b30686fd6646a1c42 Mon Sep 17 00:00:00 2001 From: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com> Date: Wed, 19 Nov 2025 09:26:16 -0500 Subject: [PATCH 2/2] Apply suggestions from code review --- src/oss/langchain/agents.mdx | 3 +-- src/oss/python/releases/langchain-v1.mdx | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/oss/langchain/agents.mdx b/src/oss/langchain/agents.mdx index 33e3bdcfe8..2a6114f4d2 100644 --- a/src/oss/langchain/agents.mdx +++ b/src/oss/langchain/agents.mdx @@ -163,8 +163,7 @@ def dynamic_model_selection(request: ModelRequest, handler) -> ModelResponse: else: model = basic_model - request = request.override(model=model) - return handler(request) + return handler(request.override(model=model)) agent = create_agent( model=basic_model, # Default model diff --git a/src/oss/python/releases/langchain-v1.mdx b/src/oss/python/releases/langchain-v1.mdx index 339d777d53..3699d735c9 100644 --- a/src/oss/python/releases/langchain-v1.mdx +++ b/src/oss/python/releases/langchain-v1.mdx @@ -173,8 +173,7 @@ class ExpertiseBasedToolMiddleware(AgentMiddleware): model = ChatOpenAI(model="gpt-5-nano") tools = [simple_search, basic_calculator] - request = request.override(model=model, tools=tools) - return handler(request) + return handler(request.override(model=model, tools=tools)) agent = create_agent( model="claude-sonnet-4-5-20250929",