vertexai: add frequency_penalty and presence_penalty #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests * Updated _VertexAICommon class to include frequency_penalty and presence_penalty attributes. * Modified test cases to incorporate new parameters in model initialization and generation configuration.
…texAICommon class * Updated docstrings for frequency_penalty and presence_penalty attributes to provide clearer explanations of their effects on token generation.
lkuligin
reviewed
Apr 25, 2025
| "Underlying model name." | ||
| temperature: Optional[float] = None | ||
| "Sampling temperature, it controls the degree of randomness in token selection." | ||
| frequency_penalty: Optional[float] = None |
Collaborator
There was a problem hiding this comment.
you need to extend _allow_model_args too, otherwise args sent to the invoke would be ignored
Contributor
Author
There was a problem hiding this comment.
Thanks. I added them to the gemma models -- that's the only place I see allowed_model_args used.
Collaborator
There was a problem hiding this comment.
I dont' think Gemma supports these params.
I'm sorry I wasn't clear, that's the place that should be modified:
Contributor
Author
There was a problem hiding this comment.
Sorry. I'm clearly missing something. frequency_penalty and presence_penalty are already there, no?
* Included frequency_penalty and presence_penalty in the GemmaVertexAIModelGarden and GemmaChatVertexAIModelGarden classes to enhance model configuration options.
lkuligin
requested changes
Apr 29, 2025
| "Underlying model name." | ||
| temperature: Optional[float] = None | ||
| "Sampling temperature, it controls the degree of randomness in token selection." | ||
| frequency_penalty: Optional[float] = None |
Collaborator
There was a problem hiding this comment.
I dont' think Gemma supports these params.
I'm sorry I wasn't clear, that's the place that should be modified:
… classes * Eliminated frequency_penalty and presence_penalty from the GemmaVertexAIModelGarden and GemmaChatVertexAIModelGarden classes to streamline model configuration options.
lkuligin
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds
frequency_penaltyandpresence_penaltyto base model.Fixes issues where initializing ChatVertexAI with a
frequency_penaltyargument would log:Unexpected argument 'frequency_penalty' provided to ChatVertexAI.Type
🐛 Bug Fix