From d9fd1194f5aa642d008d0b86efb10b89729b69dd Mon Sep 17 00:00:00 2001 From: Nuno Campos Date: Wed, 28 Feb 2024 10:28:53 -0800 Subject: [PATCH] Remove check preventing passing non-declared config keys (#18276) Thank you for contributing to LangChain! - [ ] **PR title**: "package: description" - Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [ ] **PR message**: ***Delete this entire checklist*** and replace with - **Description:** a description of the change - **Issue:** the issue # it fixes, if applicable - **Dependencies:** any dependencies required for this change - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! - [ ] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [ ] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17. --- libs/core/langchain_core/runnables/base.py | 10 ---------- libs/core/tests/unit_tests/runnables/test_runnable.py | 3 --- 2 files changed, 13 deletions(-) diff --git a/libs/core/langchain_core/runnables/base.py b/libs/core/langchain_core/runnables/base.py index 900efb1f9f3512..da4750bd5564eb 100644 --- a/libs/core/langchain_core/runnables/base.py +++ b/libs/core/langchain_core/runnables/base.py @@ -3995,16 +3995,6 @@ def __init__( runnable with a custom type. **other_kwargs: Unpacked into the base class. """ - config = config or {} - # config_specs contains the list of valid `configurable` keys - if configurable := config.get("configurable", None): - allowed_keys = set(s.id for s in bound.config_specs) - for key in configurable: - if key not in allowed_keys: - raise ValueError( - f"Configurable key '{key}' not found in runnable with" - f" config keys: {allowed_keys}" - ) super().__init__( bound=bound, kwargs=kwargs or {}, diff --git a/libs/core/tests/unit_tests/runnables/test_runnable.py b/libs/core/tests/unit_tests/runnables/test_runnable.py index 935613a18be091..696a70520b3a41 100644 --- a/libs/core/tests/unit_tests/runnables/test_runnable.py +++ b/libs/core/tests/unit_tests/runnables/test_runnable.py @@ -1278,9 +1278,6 @@ def test_configurable_fields_example() -> None: }, } - with pytest.raises(ValueError): - chain_configurable.with_config(configurable={"llm123": "chat"}) - assert ( chain_configurable.with_config(configurable={"llm": "chat"}).invoke( {"name": "John"}