Implemented support for image inputs #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AI & Gemini integrations
…AI & Gemini integrations
langchain4j
commented
Dec 29, 2023
...vertex-ai-gemini/src/test/java/dev/langchain4j/model/vertexai/VertexAiGeminiChatModelIT.java
Outdated
Show resolved
Hide resolved
|
@glaforge could you please review Gemini part? Thanks! |
glaforge
approved these changes
Dec 29, 2023
There was a problem hiding this comment.
It looks great to me!
It's interesting to see that it required quite a bit of changes here and there so it works across providers.
I'm wondering why you're not using the java.util.Base64 class instead of the internal sun one?
Otherwise, looks great and easy to use when users mix text and images!
...-gemini/src/test/java/dev/langchain4j/model/vertexai/VertexAiGeminiStreamingChatModelIT.java
Outdated
Show resolved
Hide resolved
langchain4j-vertex-ai-gemini/src/main/java/dev/langchain4j/model/vertexai/PartsMapper.java
Outdated
Show resolved
Hide resolved
...vertex-ai-gemini/src/test/java/dev/langchain4j/model/vertexai/VertexAiGeminiChatModelIT.java
Outdated
Show resolved
Hide resolved
...vertex-ai-gemini/src/test/java/dev/langchain4j/model/vertexai/VertexAiGeminiChatModelIT.java
Outdated
Show resolved
Hide resolved
...vertex-ai-gemini/src/test/java/dev/langchain4j/model/vertexai/VertexAiGeminiChatModelIT.java
Outdated
Show resolved
Hide resolved
...-gemini/src/test/java/dev/langchain4j/model/vertexai/VertexAiGeminiStreamingChatModelIT.java
Outdated
Show resolved
Hide resolved
|
@langchain4j May I know when could I access these features in a released version? |
|
@liushuaikobe most probably end of this week or during the next week. In the meantime, you can build a snapshot |
|
Awesome, this update is so timely, I just needed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for image inputs was added in LangChain4j chat API as well as OpenAI & Gemini integrations